Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove log level as RN do not use it anymore #924

Merged
merged 1 commit into from Sep 15, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Sep 15, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

ref: remove log level as RN do not use it anymore

馃挕 Motivation and Context

we had level.LOG because of RN, but now we don't need it anymore, RN removed LOG and CRITICAL to be compatible with the unified API.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

馃敭 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #924 into main will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #924      +/-   ##
============================================
+ Coverage     70.60%   70.66%   +0.06%     
  Complexity     1207     1207              
============================================
  Files           122      122              
  Lines          4466     4465       -1     
  Branches        454      454              
============================================
+ Hits           3153     3155       +2     
+ Misses         1066     1063       -3     
  Partials        247      247              
Impacted Files Coverage 螖 Complexity 螖
sentry/src/main/java/io/sentry/SentryLevel.java 100.00% <酶> (酶) 1.00 <0.00> (酶)
...entry/adapters/SentryLevelDeserializerAdapter.java 85.71% <0.00%> (+42.85%) 2.00% <0.00%> (酶%)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b6e99c2...f1e673c. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marandaneto marandaneto merged commit f7e6341 into main Sep 15, 2020
@marandaneto marandaneto deleted the ref/remove-log-level branch September 15, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants