Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not set cookies when send pii is set to false. #931

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Sep 18, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Fixes not setting cookie on Sentry Event when default-send-pii is set to false.
Cookies header name instead of Cookie has been used before.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

馃敭 Next steps

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a typo right, good catch, LGTM

@maciejwalkowiak
Copy link
Contributor Author

Yes, just a typo but in too many places ;-) Thanks for quick review!

@codecov-commenter
Copy link

Codecov Report

Merging #931 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #931   +/-   ##
=========================================
  Coverage     70.66%   70.66%           
  Complexity     1206     1206           
=========================================
  Files           122      122           
  Lines          4465     4465           
  Branches        454      454           
=========================================
  Hits           3155     3155           
  Misses         1063     1063           
  Partials        247      247           
Impacted Files Coverage 螖 Complexity 螖
...ring/SentryRequestHttpServletRequestProcessor.java 95.65% <100.00%> (酶) 10.00 <0.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 26b7a2f...391f315. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit c809455 into main Sep 18, 2020
@maciejwalkowiak maciejwalkowiak deleted the fix-spring-cookies branch September 18, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants