Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Spring Boot to 2.3.4. #932

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Upgrade Spring Boot to 2.3.4. #932

merged 1 commit into from
Sep 18, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Upgrade Spring Boot to 2.3.4.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #932 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #932   +/-   ##
=========================================
  Coverage     70.66%   70.66%           
  Complexity     1206     1206           
=========================================
  Files           122      122           
  Lines          4465     4465           
  Branches        454      454           
=========================================
  Hits           3155     3155           
  Misses         1063     1063           
  Partials        247      247           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 26b7a2f...46cc932. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit d9d857f into main Sep 18, 2020
@maciejwalkowiak maciejwalkowiak deleted the upgrade-spring-boot branch September 18, 2020 10:54
@bruno-garcia
Copy link
Member

Just a reminder to generally target the lowest possible version here.
Not to force consumers of our lib to update their apps.

@bruno-garcia
Copy link
Member

This is the latest version: https://search.maven.org/artifact/org.springframework.boot/spring-boot-starter

Do we want to go this direction?

What woud be the lowest version we can target our lib that it would still compile/work?

@bruno-garcia
Copy link
Member

We possibly need two versions here: One of the sample which can be this one (latest)
One for the lib which should be the lowest

@maciejwalkowiak
Copy link
Contributor Author

I am not sure how does it work, but when projects use spring-boot-starter-parent (default for Spring Boot), versions from our starter get overwritten by the ones specified in Spring Boot. So we are not forcing to use the latest version.

But, to make sure that it does work with the range of versions it would be nice if we could test against all of them. Not sure how to do it though.

@bruno-garcia
Copy link
Member

I find that an odd dependency resolution strategy. How do they make sure things are compatible?
If that's true we can be using an API that's not available on their older version there.

In general libraries target the lowest version they need. The app has that as a base requirement for compatibility with the framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants