Auto-configure inAppIncludes in Spring Boot integration. #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
reviewed
Oct 6, 2020
sentry-spring-boot-starter/src/main/java/io/sentry/spring/boot/InAppIncludesResolver.java
Outdated
Show resolved
Hide resolved
marandaneto
approved these changes
Oct 6, 2020
|
It alters the previous behavior so not really breaking but once users upgrade and they didnt set this propery manually before they will see a change. Does it qualify as breaking? |
I see, luckily if manually set and now automatically detected, would be still the same values, IMO it's not a breaking change but got your point, maybe let's just describe this in the release notes so we don't need to minor bump, but only patch bump, wdyt/ |
…/InAppIncludesResolver.java Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
|
yeah 3.1.0 is also good enough, wouldn't break a build but worth noting a relevant change |
?
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Auto-configure
inAppIncludesin Spring Boot integration by getting a package name from@SpringBootApplicationor@SpringBootConfigurationannotated classes.💡 Motivation and Context
Less configuration and better experience for our users.
💚 How did you test it?
📝 Checklist