Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept quotes in external configuration properties. #972

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Accept quotes in external configuration properties, like SENTRY_DSN="...".

💡 Motivation and Context

Users who migrate from old Sentry SDK version have this issue that they used to pass quoted values and now they don't work.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #972 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #972      +/-   ##
============================================
+ Coverage     71.56%   71.58%   +0.01%     
- Complexity     1289     1294       +5     
============================================
  Files           134      134              
  Lines          4723     4726       +3     
  Branches        489      489              
============================================
+ Hits           3380     3383       +3     
  Misses         1087     1087              
  Partials        256      256              
Impacted Files Coverage Δ Complexity Δ
...ava/io/sentry/config/SimplePropertiesProvider.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
.../config/EnvironmentVariablePropertiesProvider.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...entry/config/SystemPropertyPropertiesProvider.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...ntry/src/main/java/io/sentry/util/StringUtils.java 100.00% <100.00%> (ø) 12.00 <5.00> (+5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4044f35...420a693. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@bruno-garcia bruno-garcia merged commit 22003e8 into main Oct 9, 2020
@bruno-garcia bruno-garcia deleted the accept-quotes-configuration branch October 9, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants