Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(core): Use factory function to create individual plugins #229

Merged
merged 4 commits into from
May 2, 2023
Merged

ref(core): Use factory function to create individual plugins #229

merged 4 commits into from
May 2, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented May 2, 2023

This is the first step to separate concerns between plugins (e.g. so that we don't have to import webpack for the rollup plugin)

@lforst lforst requested review from AbhiPrasad and mydea May 2, 2023 12:08
AbhiPrasad
AbhiPrasad approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the sentryUnpluginFactoryFactory

@lforst lforst merged commit 12d8022 into main May 2, 2023
16 checks passed
@lforst lforst deleted the lforst-dependency-injection-architecture branch May 2, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lforst @mydea @AbhiPrasad