ref(core): Switch to v2 options #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
May 8, 2023
Comment on lines
+169
to
+178
| if (options.sourcemaps) { | ||
| if (!options.authToken) { | ||
| logger.warn("No auth token provided. Will not upload source maps."); | ||
| } else if (!options.org) { | ||
| logger.warn("No org provided. Will not upload source maps."); | ||
| } else if (!options.project) { | ||
| logger.warn("No project provided. Will not upload source maps."); | ||
| } else if (!options.sourcemaps.assets) { | ||
| logger.warn("No assets defined. Will not upload source maps."); | ||
| } else { |
There was a problem hiding this comment.
l: Personally I'd prefer to extract this validation to a function (per plugin) to declutter this one a little but feel free to leave it as is as.
There was a problem hiding this comment.
This currently has a use for TS. We could put it into a helper but I am not sure if it will actually simplify the code by a lot. Gonna leave this for now.
There was a problem hiding this comment.
Ahh I see, yeah, then let's just leave it.
| hub.setTag("finalize-release", true); | ||
| } | ||
| if (deploy) { | ||
| if (release.deploy) { | ||
| hub.setTag("add-deploy", true); | ||
| } | ||
|
|
||
| // Miscelaneous options |
There was a problem hiding this comment.
super-l: Should we add a tag for the new deleteAfterUpload option? Might be interesting to see how often it is used?
There was a problem hiding this comment.
We don't have it implemented yet but it probably doesn't hurt to add right now!
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
lforst
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to the new options as decided in https://github.com/getsentry/rfcs/blob/main/text/0086-sentry-bundler-plugins-api.md