Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Implements rewrite sources for debug ID upload #243

Merged
merged 2 commits into from
May 17, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented May 10, 2023

Adds the rewriteSources hook to the plugin which allows to modify the names of files inside the stacktrace on Sentry.

The hook is called for each individual source file and also passed the entire source map object for convenience.

The default logic if not otherwise defined is to make all the sources relative to process.cwd() or to strip away a protocol if there is one (this is mainly for webpack).

@lforst lforst requested review from Lms24 and AbhiPrasad May 10, 2023 16:11
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l (not required, just a thought): Should we add tests for this (and maybe also for the deleteSourceMaps option)?

@lforst
Copy link
Member Author

lforst commented May 17, 2023

l (not required, just a thought): Should we add tests for this (and maybe also for the deleteSourceMaps option)?

Definitely but I am gonna do that later

@lforst lforst merged commit f4446a5 into main May 17, 2023
16 checks passed
@lforst lforst deleted the lforst-rewrite-sources branch May 17, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants