Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webpack): Set minimum webpack 4 peer dep to 4.40.0 #290

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix(webpack): Set minimum webpack 4 peer dep to 4.40.0 #290

merged 1 commit into from
Jun 5, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented May 26, 2023

@lforst lforst requested review from Lms24 and mydea and removed request for Lms24 May 30, 2023 07:58
@lforst lforst self-assigned this May 31, 2023
AbhiPrasad
AbhiPrasad approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a fix? Since this is technically breaking for those who have --strict-peer-deps set.

@lforst
Copy link
Member Author

lforst commented Jun 5, 2023

Shouldn't this be a fix? Since this is technically breaking for those who have --strict-peer-deps set.

Ah true, good point. Thanks!

@lforst lforst changed the title meta: Set minimum webpack 4 peer dep to 4.40.0 fix: Set minimum webpack 4 peer dep to 4.40.0 Jun 5, 2023
@lforst lforst changed the title fix: Set minimum webpack 4 peer dep to 4.40.0 fix(webpack): Set minimum webpack 4 peer dep to 4.40.0 Jun 5, 2023
@lforst lforst merged commit 015d8fb into main Jun 5, 2023
16 checks passed
@lforst lforst deleted the lforst-set-minimum-webpack-4-peer-de branch June 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees

@lforst lforst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lforst @AbhiPrasad