Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement paths and ext options for include #73

Merged
merged 1 commit into from Oct 27, 2022

Conversation

lforst
Copy link
Member

@lforst lforst commented Oct 25, 2022

Ref: #62

This PR adds the logic to grab files the user configured via include and paths and applies logic for the correct release artifact prefixes:

  • If the user points paths to a file, it's artifact path will be its basename prefixed with the urlPrefix (eg. /foo/bar/baz.js -> ~/baz.js)
  • If the user points paths to a directory, the plugin will include all the files recursively included in that directory. The file's artifact paths will be the file path, but the part that the user provided via paths is replaced with the urlPrefix.

We also filter based on file extensions with the ext option.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Just a couple of super-l nits and questions but nothing blocking.

Let's not forget to add a note to MIGRATION.md that we're not supporting globs anymore (doesn't have to happen in this PR though)

@lforst lforst merged commit 17dbc50 into main Oct 27, 2022
@lforst lforst deleted the lforst-include-paths-and-ext branch October 27, 2022 10:38
@lforst lforst restored the lforst-include-paths-and-ext branch October 27, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants