feat(core): Add ignoreFile option
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms-option-ignorefile
branch
from
97d2348
to
df4f6d9
Compare
Lms24
force-pushed
the
lms-option-ignorefile
branch
from
df4f6d9
to
a9bf3d4
Compare
5 tasks
Lms24
changed the title
ignoreFile option (Attempt)ignoreFile option
lforst
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
ignoreFileoption and rewrites theignoreoption behaviour. Previously, we usedglob'signoreoption to pass an array of ignore rules to the library. This meant we'd get back a set of filtered files where ignore rules were already applied. However,globdoes not support negated ignore rules, meaning ignore patterns like "ignore everything except file x" wouldn't work.With this PR, we introduce a new library to the project: ignore. It lets us add rules to a rule checker (regardless of if these rules come from a file or an array). We now first collect all files with
globand subsequently filter out the ones that are ignored by the specified ignore rules. This rule checker supports all rules as specified in.gitignorespecs. Therefore, it also supports negated ignore rules.ref: #62