ref(core): Use Sentry-CLI to finalize release #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms-cli-finalize
branch
from
741ec6f
to
fb0bcf7
Compare
Lms24
force-pushed
the
lms-cli-upload
branch
2 times, most recently
from
2f2d49b
to
0961f6f
Compare
Lms24
force-pushed
the
lms-cli-finalize
branch
from
7a3cb3c
to
4a5073f
Compare
AbhiPrasad
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our own release finalization logic with Sentry CLI's implementation
RIP
Note: Since integration tests were failing because the CLI expects parameters that we didn't specify, I opted to set the
dryRunoption in our test setups. We're only testing release injection in these tests, so apart from the CLI's version detection (which still works as expected in dry run mode) we don't need any of its functionality.ref #85