Skip to content

Commit

Permalink
set enableMeasurements to be true by default
Browse files Browse the repository at this point in the history
  • Loading branch information
dashed committed Sep 17, 2020
1 parent d696e62 commit 29c4b52
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions packages/tracing/src/browser/browsertracing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export interface BrowserTracingOptions extends RequestInstrumentationOptions {
/**
* Flag to attach measurements to transactions.
*
* Default: false
* Default: true
* @hidden
*/
enableMeasurements: boolean;
Expand Down Expand Up @@ -103,7 +103,7 @@ export class BrowserTracing implements Integration {

/** Browser Tracing integration options */
public options: BrowserTracingOptions = {
enableMeasurements: false,
enableMeasurements: true,
beforeNavigate: defaultBeforeNavigate,
idleTimeout: DEFAULT_IDLE_TIMEOUT,
markBackgroundTransactions: true,
Expand Down
2 changes: 1 addition & 1 deletion packages/tracing/src/browser/metrics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const global = getGlobalObject<Window>();
export class MetricsInstrumentation {
private _lcp: Record<string, any> = {};
private _measurements: Measurements = {};
private _enableMeasurements: boolean = false;
private _enableMeasurements: boolean = true;

private _performanceCursor: number = 0;

Expand Down
2 changes: 1 addition & 1 deletion packages/tracing/test/browser/browsertracing.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ describe('BrowserTracing', () => {
const browserTracing = createBrowserTracing();

expect(browserTracing.options).toEqual({
enableMeasurements: false,
enableMeasurements: true,
beforeNavigate: expect.any(Function),
idleTimeout: DEFAULT_IDLE_TIMEOUT,
markBackgroundTransactions: true,
Expand Down

0 comments on commit 29c4b52

Please sign in to comment.