Skip to content

Commit

Permalink
chore(feedback): Adjust package resolutions for `@sentry-internal/fee…
Browse files Browse the repository at this point in the history
…dback` in Remix and NextJS Integration tests (#9733)
  • Loading branch information
Lms24 committed Dec 4, 2023
1 parent bfc63cb commit 2ae79fa
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/new-sdk-release-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ This page serves as a checklist of what to do when releasing a new SDK for the f

- [ ] Make sure it is added to the [Verdaccio config](https://github.com/getsentry/sentry-javascript/blob/develop/packages/e2e-tests/verdaccio-config/config.yaml) for the E2E tests

- [ ] If the package you're adding is a dependency of fullstack framework (e.g. Remix or NextJS) SDKs, make sure that your package is added to the integration test apps' `"resolutions"` field in their `package.json`s.

## Cutting the Release

When you’re ready to make the first release, there are a couple of steps that need to be performed in the **correct order**. Note that you can prepare the PRs at any time but the **merging oder** is important:
Expand Down
1 change: 1 addition & 0 deletions packages/nextjs/test/integration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"@sentry/replay": "file:../../../replay",
"@sentry/tracing": "file:../../../tracing",
"@sentry-internal/tracing": "file:../../../tracing-internal",
"@sentry-internal/feedback": "file:../../../feedback",
"@sentry/types": "file:../../../types",
"@sentry/utils": "file:../../../utils",
"@sentry/vercel-edge": "file:../../../vercel-edge"
Expand Down
1 change: 1 addition & 0 deletions packages/remix/test/integration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"@sentry/replay": "file:../../../replay",
"@sentry/tracing": "file:../../../tracing",
"@sentry-internal/tracing": "file:../../../tracing-internal",
"@sentry-internal/feedback": "file:../../../feedback",
"@sentry/types": "file:../../../types",
"@sentry/utils": "file:../../../utils",
"@vanilla-extract/css": "1.13.0"
Expand Down

0 comments on commit 2ae79fa

Please sign in to comment.