add tests

getsentry · Sep 11, 2023 · 460595a · 460595a
1 parent e9931f4
commit 460595a
Show file tree

Hide file tree

Showing 2 changed files with 65 additions and 3 deletions.
diff --git a/packages/replay/src/util/addEvent.ts b/packages/replay/src/util/addEvent.ts
@@ -88,7 +88,8 @@ async function _addEvent(
   }
 }
 
-function shouldAddEvent(replay: ReplayContainer, event: RecordingEvent): boolean {
+/** Exported only for tests. */
+export function shouldAddEvent(replay: ReplayContainer, event: RecordingEvent): boolean {
   if (!replay.eventBuffer || replay.isPaused() || !replay.isEnabled()) {
     return false;
   }

diff --git a/packages/replay/test/unit/util/addEvent.test.ts b/packages/replay/test/unit/util/addEvent.test.ts
@@ -1,9 +1,9 @@
 import 'jsdom-worker';
 
 import { BASE_TIMESTAMP } from '../..';
-import { REPLAY_MAX_EVENT_BUFFER_SIZE } from '../../../src/constants';
+import { MAX_REPLAY_DURATION, REPLAY_MAX_EVENT_BUFFER_SIZE, SESSION_IDLE_PAUSE_DURATION } from '../../../src/constants';
 import type { EventBufferProxy } from '../../../src/eventBuffer/EventBufferProxy';
-import { addEvent } from '../../../src/util/addEvent';
+import { addEvent, shouldAddEvent } from '../../../src/util/addEvent';
 import { getTestEventIncremental } from '../../utils/getTestEvent';
 import { setupReplayContainer } from '../../utils/setupReplayContainer';
 import { useFakeTimers } from '../../utils/use-fake-timers';
@@ -57,4 +57,65 @@ describe('Unit | util | addEvent', () => {
 
     expect(replay.isEnabled()).toEqual(false);
   });
+
+  describe('shouldAddEvent', () => {
+    beforeEach(() => {
+      jest.setSystemTime(BASE_TIMESTAMP);
+    });
+
+    it('returns true by default', () => {
+      const replay = setupReplayContainer({});
+      const event = getTestEventIncremental({ timestamp: BASE_TIMESTAMP });
+
+      expect(shouldAddEvent(replay, event)).toEqual(true);
+    });
+
+    it('returns false when paused', () => {
+      const replay = setupReplayContainer({});
+      const event = getTestEventIncremental({ timestamp: BASE_TIMESTAMP });
+
+      replay.pause();
+
+      expect(shouldAddEvent(replay, event)).toEqual(false);
+    });
+
+    it('returns false when disabled', async () => {
+      const replay = setupReplayContainer({});
+      const event = getTestEventIncremental({ timestamp: BASE_TIMESTAMP });
+
+      await replay.stop();
+
+      expect(shouldAddEvent(replay, event)).toEqual(false);
+    });
+
+    it('returns false if there is no eventBuffer', () => {
+      const replay = setupReplayContainer({});
+      const event = getTestEventIncremental({ timestamp: BASE_TIMESTAMP });
+
+      replay.eventBuffer = null;
+
+      expect(shouldAddEvent(replay, event)).toEqual(false);
+    });
+
+    it('returns false when event is too old', () => {
+      const replay = setupReplayContainer({});
+      const event = getTestEventIncremental({ timestamp: BASE_TIMESTAMP - SESSION_IDLE_PAUSE_DURATION - 1 });
+
+      expect(shouldAddEvent(replay, event)).toEqual(false);
+    });
+
+    it('returns false if event is too long after initial timestamp', () => {
+      const replay = setupReplayContainer({});
+      const event = getTestEventIncremental({ timestamp: BASE_TIMESTAMP + MAX_REPLAY_DURATION + 1 });
+
+      expect(shouldAddEvent(replay, event)).toEqual(false);
+    });
+
+    it('returns true if event is withing max duration after after initial timestamp', () => {
+      const replay = setupReplayContainer({});
+      const event = getTestEventIncremental({ timestamp: BASE_TIMESTAMP + MAX_REPLAY_DURATION - 1 });
+
+      expect(shouldAddEvent(replay, event)).toEqual(true);
+    });
+  });
 });