chore(eslint): Add eslint to eslint plugin (#4537)

getsentry · Feb 11, 2022 · 487945f · 487945f
1 parent 9c01a5e
commit 487945f
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 26 deletions.
diff --git a/packages/eslint-plugin-sdk/.eslintrc.js b/packages/eslint-plugin-sdk/.eslintrc.js
@@ -0,0 +1,3 @@
+module.exports = {
+  extends: ['../../.eslintrc.js'],
+};
diff --git a/packages/eslint-plugin-sdk/package.json b/packages/eslint-plugin-sdk/package.json
@@ -26,8 +26,12 @@
   },
   "scripts": {
     "link:yarn": "yarn link",
-    "lint": "prettier --check \"{src,test}/**/*.js\"",
-    "fix": "prettier --write \"{src,test}/**/*.js\"",
+    "fix": "run-s fix:eslint fix:prettier",
+    "fix:eslint": "eslint . --format stylish --fix",
+    "fix:prettier": "prettier --write \"{src,test}/**/*.js\"",
+    "lint": "run-s lint:prettier lint:eslint",
+    "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
+    "lint:prettier": "prettier --check \"{src,test}/**/*.js\"",
     "test": "mocha test --recursive",
     "pack": "npm pack",
     "circularDepCheck": "madge --circular src/index.js"

diff --git a/packages/eslint-plugin-sdk/src/index.js b/packages/eslint-plugin-sdk/src/index.js
@@ -4,9 +4,9 @@
  */
 'use strict';
 
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 // Plugin Definition
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 
 module.exports = {
   rules: {

diff --git a/packages/eslint-plugin-sdk/src/rules/no-async-await.js b/packages/eslint-plugin-sdk/src/rules/no-async-await.js
@@ -4,9 +4,9 @@
  */
 'use strict';
 
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 // Rule Definition
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 
 module.exports = {
   meta: {
@@ -22,15 +22,15 @@ module.exports = {
   create: function (context) {
     // variables should be defined here
 
-    //----------------------------------------------------------------------
+    // ----------------------------------------------------------------------
     // Helpers
-    //----------------------------------------------------------------------
+    // ----------------------------------------------------------------------
 
     // any helper functions should go here or else delete this section
 
-    //----------------------------------------------------------------------
+    // ----------------------------------------------------------------------
     // Public
-    //----------------------------------------------------------------------
+    // ----------------------------------------------------------------------
 
     return {
       FunctionDeclaration(node) {

diff --git a/packages/eslint-plugin-sdk/src/rules/no-eq-empty.js b/packages/eslint-plugin-sdk/src/rules/no-eq-empty.js
@@ -4,9 +4,9 @@
  */
 'use strict';
 
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 // Rule Definition
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 
 module.exports = {
   meta: {
@@ -25,15 +25,15 @@ module.exports = {
   create: function (context) {
     // variables should be defined here
 
-    //----------------------------------------------------------------------
+    // ----------------------------------------------------------------------
     // Helpers
-    //----------------------------------------------------------------------
+    // ----------------------------------------------------------------------
 
     // any helper functions should go here or else delete this section
 
-    //----------------------------------------------------------------------
+    // ----------------------------------------------------------------------
     // Public
-    //----------------------------------------------------------------------
+    // ----------------------------------------------------------------------
 
     return {
       BinaryExpression(node) {

diff --git a/packages/eslint-plugin-sdk/test/lib/rules/no-async-await.js b/packages/eslint-plugin-sdk/test/lib/rules/no-async-await.js
@@ -4,16 +4,17 @@
  */
 'use strict';
 
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 // Requirements
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 
-const rule = require('../../../src/rules/no-async-await');
 const RuleTester = require('eslint').RuleTester;
 
-//------------------------------------------------------------------------------
+const rule = require('../../../src/rules/no-async-await');
+
+// ------------------------------------------------------------------------------
 // Tests
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 
 RuleTester.setDefaultConfig({
   parserOptions: {

diff --git a/packages/eslint-plugin-sdk/test/lib/rules/no-eq-empty.js b/packages/eslint-plugin-sdk/test/lib/rules/no-eq-empty.js
@@ -4,16 +4,17 @@
  */
 'use strict';
 
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 // Requirements
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 
-const rule = require('../../../src/rules/no-eq-empty');
 const RuleTester = require('eslint').RuleTester;
 
-//------------------------------------------------------------------------------
+const rule = require('../../../src/rules/no-eq-empty');
+
+// ------------------------------------------------------------------------------
 // Tests
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 
 RuleTester.setDefaultConfig({
   parserOptions: {