feat(v7/core): Backport ResizeObserver and googletag default filt…

…ers (#11210) Backport two additional default error event filters to our `inboundFilters` integration: * #10845 * #11208
getsentry · Mar 20, 2024 · 4caa946 · 4caa946
1 parent c7306da
commit 4caa946
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 3 deletions.
diff --git a/.size-limit.js b/.size-limit.js
@@ -52,7 +52,7 @@ module.exports = [
     path: 'packages/browser/build/npm/esm/index.js',
     import: '{ init, browserTracingIntegration }',
     gzip: true,
-    limit: '36 KB',
+    limit: '37 KB',
   },
   {
     name: '@sentry/browser (incl. Feedback) - Webpack (gzipped)',

diff --git a/packages/core/src/integrations/inboundfilters.ts b/packages/core/src/integrations/inboundfilters.ts
@@ -6,7 +6,12 @@ import { convertIntegrationFnToClass, defineIntegration } from '../integration';
 
 // "Script error." is hard coded into browsers for errors that it can't read.
 // this is the result of a script being pulled in from an external domain and CORS.
-const DEFAULT_IGNORE_ERRORS = [/^Script error\.?$/, /^Javascript error: Script error\.? on line 0$/];
+const DEFAULT_IGNORE_ERRORS = [
+  /^Script error\.?$/,
+  /^Javascript error: Script error\.? on line 0$/,
+  /^ResizeObserver loop completed with undelivered notifications.$/,
+  /^Cannot redefine property: googletag$/,
+];
 
 const DEFAULT_IGNORE_TRANSACTIONS = [
   /^.*\/healthcheck$/,

diff --git a/packages/core/test/lib/integrations/inboundfilters.test.ts b/packages/core/test/lib/integrations/inboundfilters.test.ts
@@ -188,6 +188,28 @@ const SCRIPT_ERROR_EVENT: Event = {
   },
 };
 
+const RESIZEOBSERVER_EVENT: Event = {
+  exception: {
+    values: [
+      {
+        type: 'Error',
+        value: 'ResizeObserver loop completed with undelivered notifications.',
+      },
+    ],
+  },
+};
+
+const GOOGLETAG_EVENT: Event = {
+  exception: {
+    values: [
+      {
+        type: 'TypeError',
+        value: 'Cannot redefine property: googletag',
+      },
+    ],
+  },
+};
+
 const MALFORMED_EVENT: Event = {
   exception: {
     values: [
@@ -304,11 +326,21 @@ describe('InboundFilters', () => {
       expect(eventProcessor(EXCEPTION_EVENT, {})).toBe(null);
     });
 
-    it('uses default filters', () => {
+    it('uses default filters (script error)', () => {
       const eventProcessor = createInboundFiltersEventProcessor();
       expect(eventProcessor(SCRIPT_ERROR_EVENT, {})).toBe(null);
     });
 
+    it('uses default filters (ResizeObserver)', () => {
+      const eventProcessor = createInboundFiltersEventProcessor();
+      expect(eventProcessor(RESIZEOBSERVER_EVENT, {})).toBe(null);
+    });
+
+    it('uses default filters (googletag)', () => {
+      const eventProcessor = createInboundFiltersEventProcessor();
+      expect(eventProcessor(GOOGLETAG_EVENT, {})).toBe(null);
+    });
+
     it('filters on last exception when multiple present', () => {
       const eventProcessor = createInboundFiltersEventProcessor({
         ignoreErrors: ['incorrect type given for parameter `chewToy`'],