Adjust test and add comment to browser impl

getsentry · Mar 27, 2024 · 606c389 · 606c389
1 parent 926984e
commit 606c389
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 33 deletions.
diff --git a/packages/angular/test/sdk.test.ts b/packages/angular/test/sdk.test.ts
@@ -1,6 +1,6 @@
 import * as SentryBrowser from '@sentry/browser';
 import { vi } from 'vitest';
-import { getDefaultIntegrations, init } from '../src/index';
+import { getDefaultIntegrations, init } from '../src/sdk';
 
 describe('init', () => {
   it('sets the Angular version (if available) in the global scope', () => {
@@ -14,39 +14,16 @@ describe('init', () => {
     expect(setContextSpy).toHaveBeenCalledWith('angular', { version: 14 });
   });
 
-  describe('filtering out the `BrowserApiErrors` integration', () => {
-    const browserInitSpy = vi.spyOn(SentryBrowser, 'init');
+  it('does not include the BrowserApiErrors integration', () => {
+    const browserDefaultIntegrationsWithoutBrowserApiErrors = SentryBrowser.getDefaultIntegrations()
+      .filter(i => i.name !== 'BrowserApiErrors')
+      .map(i => i.name)
+      .sort();
 
-    beforeEach(() => {
-      browserInitSpy.mockClear();
-    });
+    const angularDefaultIntegrations = getDefaultIntegrations()
+      .map(i => i.name)
+      .sort();
 
-    it('filters if `defaultIntegrations` is not set', () => {
-      init({});
-
-      expect(browserInitSpy).toHaveBeenCalledTimes(1);
-
-      const options = browserInitSpy.mock.calls[0][0] || {};
-      expect(options.defaultIntegrations).not.toContainEqual(expect.objectContaining({ name: 'BrowserApiErrors' }));
-    });
-
-    it("doesn't filter if `defaultIntegrations` is set to `false`", () => {
-      init({ defaultIntegrations: false });
-
-      expect(browserInitSpy).toHaveBeenCalledTimes(1);
-
-      const options = browserInitSpy.mock.calls[0][0] || {};
-      expect(options.defaultIntegrations).toEqual(false);
-    });
-
-    it("doesn't filter if `defaultIntegrations` is overwritten", () => {
-      const defaultIntegrations = getDefaultIntegrations({});
-      init({ defaultIntegrations });
-
-      expect(browserInitSpy).toHaveBeenCalledTimes(1);
-
-      const options = browserInitSpy.mock.calls[0][0] || {};
-      expect(options.defaultIntegrations).toEqual(defaultIntegrations);
-    });
+    expect(angularDefaultIntegrations).toEqual(browserDefaultIntegrationsWithoutBrowserApiErrors);
   });
 });
diff --git a/packages/browser/src/sdk.ts b/packages/browser/src/sdk.ts
@@ -32,6 +32,10 @@ import { makeFetchTransport } from './transports/fetch';
 
 /** Get the default integrations for the browser SDK. */
 export function getDefaultIntegrations(_options: Options): Integration[] {
+  /**
+   * Note: Please make sure this stays in sync with Angular SDK, which re-exports
+   * `getDefaultIntegrations` but with an adjusted set of integrations.
+   */
   return [
     inboundFiltersIntegration(),
     functionToStringIntegration(),