feat(core): Add Googletag error to InboundFilters default ignore list

test biome :(
getsentry · Mar 20, 2024 · 64dc42f · 64dc42f
1 parent 0b8540f
commit 64dc42f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/packages/core/src/integrations/inboundfilters.ts b/packages/core/src/integrations/inboundfilters.ts
@@ -10,6 +10,7 @@ const DEFAULT_IGNORE_ERRORS = [
   /^Script error\.?$/,
   /^Javascript error: Script error\.? on line 0$/,
   /^ResizeObserver loop completed with undelivered notifications.$/,
+  /^Cannot redefine property: googletag$/,
 ];
 
 /** Options for the InboundFilters integration */

diff --git a/packages/core/test/lib/integrations/inboundfilters.test.ts b/packages/core/test/lib/integrations/inboundfilters.test.ts
@@ -198,6 +198,17 @@ const RESIZEOBSERVER_EVENT: Event = {
   },
 };
 
+const GOOGLETAG_EVENT: Event = {
+  exception: {
+    values: [
+      {
+        type: 'TypeError',
+        value: 'Cannot redefine property: googletag',
+      },
+    ],
+  },
+};
+
 const MALFORMED_EVENT: Event = {
   exception: {
     values: [
@@ -299,16 +310,21 @@ describe('InboundFilters', () => {
       expect(eventProcessor(EXCEPTION_EVENT, {})).toBe(null);
     });
 
-    it('uses default filters', () => {
+    it('uses default filters (script error)', () => {
       const eventProcessor = createInboundFiltersEventProcessor();
       expect(eventProcessor(SCRIPT_ERROR_EVENT, {})).toBe(null);
     });
 
-    it('uses default filters ResizeObserver', () => {
+    it('uses default filters (ResizeObserver)', () => {
       const eventProcessor = createInboundFiltersEventProcessor();
       expect(eventProcessor(RESIZEOBSERVER_EVENT, {})).toBe(null);
     });
 
+    it('uses default filters (googletag)', () => {
+      const eventProcessor = createInboundFiltersEventProcessor();
+      expect(eventProcessor(GOOGLETAG_EVENT, {})).toBe(null);
+    });
+
     it('filters on last exception when multiple present', () => {
       const eventProcessor = createInboundFiltersEventProcessor({
         ignoreErrors: ['incorrect type given for parameter `chewToy`'],