chore(ci): Make "Required Tests passed" job depend on artifact upload…

… and other required jobs (#8751)

Adjust our final "Required Tests Passed" CI job to not only
depend on required _test_ jobs but on _all_ required jobs. Specifically,
this adds

* Lint
* Circular deps check
* Most importantly: Upload Artifacts

With this change, we can configure craft's status provider to
specifically wait for this job which should fix the artifacts download
timeout (getsentry/craft#482). It's worth
noting that this PR will only fix this timeout in our repo and in a way
we're adjusting to the status provider check. However, given that we're
apparently the only repo where this happens, it's probably justified and
it makes things more explicit.

.github/workflows/build.yml

@@ -855,8 +855,8 @@ jobs:
         timeout-minutes: 5
         run: yarn test:assert
 
-  job_required_tests:
-    name: All required tests passed or skipped
+  job_required_jobs_passed:
+    name: All required jobs passed or were skipped
     needs:
       [
         job_build,
@@ -870,6 +870,9 @@ jobs:
         job_browser_loader_tests,
         job_remix_integration_tests,
         job_e2e_tests,
+        job_artifacts,
+        job_lint,
+        job_circular_dep_check,
       ]
     # Always run this, even if a dependent job failed
     if: always()