fix: Use event_id from hint given by top-level hub calls (#2396)

getsentry · Jan 29, 2020 · 6cc62f9 · 6cc62f9
1 parent bd4abef
commit 6cc62f9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/core/src/baseclient.ts b/packages/core/src/baseclient.ts
@@ -143,6 +143,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
         logger.error(reason);
         this._processing = false;
       });
+
     return eventId;
   }
 
@@ -284,7 +285,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
     }
 
     if (prepared.event_id === undefined) {
-      prepared.event_id = uuid4();
+      prepared.event_id = hint && hint.event_id ? hint.event_id : uuid4();
     }
 
     this._addIntegrations(prepared.sdk);

diff --git a/packages/core/test/lib/base.test.ts b/packages/core/test/lib/base.test.ts
@@ -234,6 +234,17 @@ describe('BaseClient', () => {
       });
     });
 
+    test('adds event_id from hint if available', () => {
+      expect.assertions(1);
+      const client = new TestClient({ dsn: PUBLIC_DSN });
+      const scope = new Scope();
+      client.captureEvent({ message: 'message' }, { event_id: 'wat' }, scope);
+      expect(TestBackend.instance!.event!).toEqual({
+        event_id: 'wat',
+        message: 'message',
+      });
+    });
+
     test('adds the configured environment', () => {
       expect.assertions(1);
       const client = new TestClient({