actually test with a real react-native stack

getsentry · Jan 31, 2020 · 7b3d017 · 7b3d017
1 parent a61b41b
commit 7b3d017
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 18 deletions.
diff --git a/packages/browser/test/unit/tracekit/original.test.ts b/packages/browser/test/unit/tracekit/original.test.ts
@@ -927,20 +927,20 @@ describe('Tracekit - Original Tests', () => {
   it('should parse React Native errors on Android Hermes', () => {
     const stackFrames = computeStackTrace(ANDROID_REACT_NATIVE_HERMES);
     expect(stackFrames).to.be.ok;
-    expect(stackFrames.stack.length).to.equal(6);
+    expect(stackFrames.stack.length).to.equal(26);
     expect(stackFrames.stack[0]).to.deep.equal({
-      url: 'unknown',
-      func: 'foo',
+      url: 'index.android.bundle',
+      func: 'onPress',
       args: [],
       line: 1,
-      column: 11939,
+      column: 452701,
     });
-    expect(stackFrames.stack[5]).to.deep.equal({
-      url: 'unknown',
-      func: 'global',
-      args: [],
-      line: 1,
-      column: 508,
+    expect(stackFrames.stack[3]).to.deep.equal({
+      url: 'native',
+      func: '_receiveSignal',
+      args: ['native'],
+      line: null,
+      column: null,
     });
   });
 });
diff --git a/packages/browser/test/unit/tracekit/originalfixtures.ts b/packages/browser/test/unit/tracekit/originalfixtures.ts
@@ -483,16 +483,34 @@ export const ANDROID_REACT_NATIVE_PROD = {
     '[native code]',
 };
 
-// NOTE: this was obtained by creating a metro+hermes bundle manually and running it through hermes on the command line.
-// not sure how different it is when actually running it in react-native properly.
 export const ANDROID_REACT_NATIVE_HERMES = {
   message: 'Error: lets throw!',
   name: 'Error',
   stack:
-    'at foo (address at unknown:1:11939)\n' +
-    'at anonymous (address at unknown:1:11857)\n' +
-    'at loadModuleImplementation (address at unknown:1:2608)\n' +
-    'at guardedLoadModule (address at unknown:1:1973)\n' +
-    'at metroRequire (address at unknown:1:1494)\n' +
-    'at global (address at unknown:1:508)',
+    'at onPress (address at index.android.bundle:1:452701)\n' +
+    'at anonymous (address at index.android.bundle:1:224280)\n' +
+    'at _performSideEffectsForTransition (address at index.android.bundle:1:230843)\n' +
+    'at _receiveSignal (native)\n' +
+    'at touchableHandleResponderRelease (native)\n' +
+    'at onResponderRelease (native)\n' +
+    'at apply (native)\n' +
+    'at b (address at index.android.bundle:1:74037)\n' +
+    'at apply (native)\n' +
+    'at k (address at index.android.bundle:1:74094)\n' +
+    'at apply (native)\n' +
+    'at C (address at index.android.bundle:1:74126)\n' +
+    'at N (address at index.android.bundle:1:74267)\n' +
+    'at A (address at index.android.bundle:1:74709)\n' +
+    'at forEach (native)\n' +
+    'at z (address at index.android.bundle:1:74642)\n' +
+    'at anonymous (address at index.android.bundle:1:77747)\n' +
+    'at _e (address at index.android.bundle:1:127755)\n' +
+    'at Ne (address at index.android.bundle:1:77238)\n' +
+    'at Ue (address at index.android.bundle:1:77571)\n' +
+    'at receiveTouches (address at index.android.bundle:1:122512)\n' +
+    'at apply (native)\n' +
+    'at value (address at index.android.bundle:1:33176)\n' +
+    'at anonymous (address at index.android.bundle:1:31603)\n' +
+    'at value (address at index.android.bundle:1:32776)\n' +
+    'at value (address at index.android.bundle:1:31561)',
 };