hope to fix "faulty route handlers"

getsentry · Mar 19, 2024 · 815b156 · 815b156
1 parent 0f68238
commit 815b156
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/route-handlers.test.ts b/dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/route-handlers.test.ts
@@ -48,7 +48,7 @@ test('Should record exceptions and transactions for faulty route handlers', asyn
   const routehandlerTransaction = await routehandlerTransactionPromise;
   const routehandlerError = await errorEventPromise;
 
-  expect(routehandlerTransaction.contexts?.trace?.status).toBe('internal_error');
+  expect(routehandlerTransaction.contexts?.trace?.status).toBe('unknown_error');
   expect(routehandlerTransaction.contexts?.trace?.op).toBe('http.server');
 
   expect(routehandlerError.exception?.values?.[0].value).toBe('route-handler-error');

diff --git a/packages/nextjs/src/common/wrapRouteHandlerWithSentry.ts b/packages/nextjs/src/common/wrapRouteHandlerWithSentry.ts
@@ -11,7 +11,7 @@ import {
 } from '@sentry/core';
 import { winterCGHeadersToDict } from '@sentry/utils';
 
-import { isRedirectNavigationError } from './nextNavigationErrorUtils';
+import { isNotFoundNavigationError, isRedirectNavigationError } from './nextNavigationErrorUtils';
 import type { RouteHandlerContext } from './types';
 import { platformSupportsStreaming } from './utils/platformSupportsStreaming';
 import { flushQueue } from './utils/responseEnd';
@@ -57,7 +57,11 @@ export function wrapRouteHandlerWithSentry<F extends (...args: any[]) => any>(
                     () => originalFunction.apply(thisArg, args),
                     error => {
                       // Next.js throws errors when calling `redirect()`. We don't wanna report these.
-                      if (!isRedirectNavigationError(error)) {
+                      if (isRedirectNavigationError(error)) {
+                        // Don't do anything
+                      } else if (isNotFoundNavigationError(error)) {
+                        setHttpStatus(span, 404);
+                      } else {
                         captureException(error, {
                           mechanism: {
                             handled: false,