PR feedback

getsentry · Apr 3, 2023 · 84f5ec4 · 84f5ec4
1 parent d126e00
commit 84f5ec4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/utils/src/instrument.ts b/packages/utils/src/instrument.ts
@@ -227,9 +227,10 @@ export function parseFetchArgs(fetchArgs: unknown[]): { method: string; url: str
     };
   }
 
+  const arg = fetchArgs[0];
   return {
-    url: getUrlFromResource(fetchArgs[0] as FetchResource),
-    method: 'GET',
+    url: getUrlFromResource(arg as FetchResource),
+    method: hasProp(arg, 'method') ? String(arg.method).toUpperCase() : 'GET',
   };
 }
 

diff --git a/packages/utils/test/instrument.test.ts b/packages/utils/test/instrument.test.ts
@@ -6,6 +6,11 @@ describe('instrument', () => {
       ['string URL only', ['http://example.com'], { method: 'GET', url: 'http://example.com' }],
       ['URL object only', [new URL('http://example.com')], { method: 'GET', url: 'http://example.com/' }],
       ['Request URL only', [{ url: 'http://example.com' }], { method: 'GET', url: 'http://example.com' }],
+      [
+        'Request URL & method only',
+        [{ url: 'http://example.com', method: 'post' }],
+        { method: 'POST', url: 'http://example.com' },
+      ],
       [
         'string URL & options',
         ['http://example.com', { method: 'post' }],