fix(replay): Fix debounce when maxWait == wait (#7208)

Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
getsentry · Feb 17, 2023 · aacdf2b · aacdf2b
1 parent 8305b94
commit aacdf2b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/packages/replay/src/util/debounce.ts b/packages/replay/src/util/debounce.ts
@@ -57,7 +57,7 @@ export function debounce(func: CallbackFunction, wait: number, options?: Debounc
     }
     timerId = setTimeout(invokeFunc, wait);
 
-    if (maxWait && maxTimerId === undefined && maxWait !== wait) {
+    if (maxWait && maxTimerId === undefined) {
       maxTimerId = setTimeout(invokeFunc, maxWait);
     }
 

diff --git a/packages/replay/test/unit/util/debounce.test.ts b/packages/replay/test/unit/util/debounce.test.ts
@@ -246,14 +246,27 @@ describe('Unit | util | debounce', () => {
     const debouncedCallback = debounce(callback, 100, { maxWait: 100 });
 
     debouncedCallback();
-    jest.advanceTimersByTime(100);
+    jest.advanceTimersByTime(25);
+    debouncedCallback();
+    jest.advanceTimersByTime(25);
+    debouncedCallback();
+    jest.advanceTimersByTime(25);
+    debouncedCallback();
+    jest.advanceTimersByTime(25);
 
     expect(callback).toHaveBeenCalledTimes(1);
 
     const retval = debouncedCallback();
     expect(retval).toBe('foo');
 
-    jest.advanceTimersByTime(100);
+    jest.advanceTimersByTime(25);
+    debouncedCallback();
+    jest.advanceTimersByTime(25);
+    debouncedCallback();
+    jest.advanceTimersByTime(25);
+    debouncedCallback();
+    jest.advanceTimersByTime(25);
+
     expect(callback).toHaveBeenCalledTimes(2);
   });
 });