Merge pull request #9417 from getsentry/prepare-release/7.77.0

meta: Update CHANGELOG for 7.77.0
getsentry · Oct 31, 2023 · cf4df75 · cf4df75
2 parents 136ca9c + 3e619dc
commit cf4df75
Show file tree

Hide file tree

Showing 52 changed files with 4,855 additions and 174 deletions.
diff --git a/.size-limit.js b/.size-limit.js
@@ -21,6 +21,7 @@ module.exports = [
           __RRWEB_EXCLUDE_CANVAS__: true,
           __RRWEB_EXCLUDE_SHADOW_DOM__: true,
           __RRWEB_EXCLUDE_IFRAME__: true,
+          __SENTRY_EXCLUDE_REPLAY_WORKER__: true,
         }),
       );
       return config;

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,17 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 7.77.0
+
+- feat: Move LinkedErrors integration to @sentry/core (#9404)
+- feat(remix): Update sentry-cli version to ^2.21.2 (#9401)
+- feat(replay): Allow to treeshake & configure compression worker URL (#9409)
+- fix(angular-ivy): Adjust package entry points to support Angular 17 with SSR config (#9412)
+- fix(feedback): Fixing feedback import (#9403)
+- fix(nextjs): Match only numbers as orgid in tunnelRoute (#9416)
+- fix(nextjs): Strictly validate tunnel target parameters (#9415)
+- fix(utils): Avoid keeping a reference of last used event (#9387)
+
 ## 7.76.0
 
 ### Important Changes

diff --git a/packages/angular-ivy/package.json b/packages/angular-ivy/package.json
@@ -46,7 +46,7 @@
     "build:watch": "yarn build:syncSymlinks && yarn build:transpile:watch",
     "build:dev:watch": "yarn build:watch",
     "build:transpile:watch": "ng build --watch",
-    "build:tarball": "npm pack ./build",
+    "build:tarball": "ts-node ./scripts/prepack.ts && npm pack ./build",
     "build:syncSymlinks": "ts-node ./scripts/syncSourceFiles.ts",
     "circularDepCheck": "madge --circular src/index.ts",
     "clean": "rimraf build coverage sentry-angular-ivy-*.tgz",
@@ -56,7 +56,7 @@
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --format stylish",
     "lint:prettier": "prettier --check \"{src,test,scripts}/**/**.ts\"",
-    "yalc:publish": "yalc publish build --push --sig"
+    "yalc:publish": "ts-node ./scripts/prepack.ts && yalc publish build --push --sig"
   },
   "volta": {
     "extends": "../../package.json"

diff --git a/packages/angular-ivy/scripts/prepack.ts b/packages/angular-ivy/scripts/prepack.ts
@@ -0,0 +1,27 @@
+import * as fs from 'fs';
+import * as path from 'path';
+
+type PackageJson = {
+  main?: string;
+  type?: string;
+  nx?: string;
+  volta?: any;
+};
+
+const buildDir = path.join(process.cwd(), 'build');
+const pkjJsonPath = path.join(buildDir, 'package.json');
+const pkgJson: PackageJson = JSON.parse(fs.readFileSync(pkjJsonPath).toString());
+
+// This is necessary for Angular 17+ compatibility when SSR is configured which switches dev mode to using Vite.
+// Deleting "main" and adding "type": "module" will direct Vite to
+// use the fesm2015 bundle instead of the UMD bundle.
+delete pkgJson.main;
+pkgJson.type = 'module';
+
+// no need to keep around other properties that are only relevant for our reop:
+delete pkgJson.nx;
+delete pkgJson.volta;
+
+fs.writeFileSync(pkjJsonPath, JSON.stringify(pkgJson, null, 2));
+
+console.log('Adjusted package.json for Angular 17+ compatibility.');
diff --git a/packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/click/template.html b/packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/click/template.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+    <title></title>
+  </head>
+  <body>
+    <button id="button1" type="button">Button 1</button>
+    <button id="button2" type="button">Button 2</button>
+  </body>
+</html>
diff --git a/packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/click/test.ts b/packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/click/test.ts
@@ -0,0 +1,59 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
+
+sentryTest('captures Breadcrumb for clicks & debounces them for a second', async ({ getLocalTestUrl, page }) => {
+  const url = await getLocalTestUrl({ testDir: __dirname });
+
+  await page.route('**/foo', route => {
+    return route.fulfill({
+      status: 200,
+      body: JSON.stringify({
+        userNames: ['John', 'Jane'],
+      }),
+      headers: {
+        'Content-Type': 'application/json',
+      },
+    });
+  });
+
+  const promise = getFirstSentryEnvelopeRequest<Event>(page);
+
+  await page.goto(url);
+
+  await page.click('#button1');
+  // not debounced because other target
+  await page.click('#button2');
+  // This should be debounced
+  await page.click('#button2');
+
+  // Wait a second for the debounce to finish
+  await page.waitForTimeout(1000);
+  await page.click('#button2');
+
+  await page.evaluate('Sentry.captureException("test exception")');
+
+  const eventData = await promise;
+
+  expect(eventData.exception?.values).toHaveLength(1);
+
+  expect(eventData.breadcrumbs).toEqual([
+    {
+      timestamp: expect.any(Number),
+      category: 'ui.click',
+      message: 'body > button#button1[type="button"]',
+    },
+    {
+      timestamp: expect.any(Number),
+      category: 'ui.click',
+      message: 'body > button#button2[type="button"]',
+    },
+    {
+      timestamp: expect.any(Number),
+      category: 'ui.click',
+      message: 'body > button#button2[type="button"]',
+    },
+  ]);
+});
diff --git a/packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/init.js b/packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/init.js
@@ -0,0 +1,10 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  defaultIntegrations: false,
+  integrations: [new Sentry.Integrations.Breadcrumbs()],
+  sampleRate: 1,
+});
diff --git a/...ges/browser-integration-tests/suites/integrations/Breadcrumbs/dom/textInput/template.html b/...ges/browser-integration-tests/suites/integrations/Breadcrumbs/dom/textInput/template.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+    <title></title>
+  </head>
+  <body>
+    <input id="input1" type="text" />
+    <input id="input2" type="text" />
+  </body>
+</html>
diff --git a/packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/textInput/test.ts b/packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/textInput/test.ts
@@ -0,0 +1,66 @@
+import { expect } from '@playwright/test';
+import type { Event } from '@sentry/types';
+
+import { sentryTest } from '../../../../../utils/fixtures';
+import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
+
+sentryTest('captures Breadcrumb for events on inputs & debounced them', async ({ getLocalTestUrl, page }) => {
+  const url = await getLocalTestUrl({ testDir: __dirname });
+
+  await page.route('**/foo', route => {
+    return route.fulfill({
+      status: 200,
+      body: JSON.stringify({
+        userNames: ['John', 'Jane'],
+      }),
+      headers: {
+        'Content-Type': 'application/json',
+      },
+    });
+  });
+
+  const promise = getFirstSentryEnvelopeRequest<Event>(page);
+
+  await page.goto(url);
+
+  await page.click('#input1');
+  // Not debounced because other event type
+  await page.type('#input1', 'John', { delay: 1 });
+  // This should be debounced
+  await page.type('#input1', 'Abby', { delay: 1 });
+  // not debounced because other target
+  await page.type('#input2', 'Anne', { delay: 1 });
+
+  // Wait a second for the debounce to finish
+  await page.waitForTimeout(1000);
+  await page.type('#input2', 'John', { delay: 1 });
+
+  await page.evaluate('Sentry.captureException("test exception")');
+
+  const eventData = await promise;
+
+  expect(eventData.exception?.values).toHaveLength(1);
+
+  expect(eventData.breadcrumbs).toEqual([
+    {
+      timestamp: expect.any(Number),
+      category: 'ui.click',
+      message: 'body > input#input1[type="text"]',
+    },
+    {
+      timestamp: expect.any(Number),
+      category: 'ui.input',
+      message: 'body > input#input1[type="text"]',
+    },
+    {
+      timestamp: expect.any(Number),
+      category: 'ui.input',
+      message: 'body > input#input2[type="text"]',
+    },
+    {
+      timestamp: expect.any(Number),
+      category: 'ui.input',
+      message: 'body > input#input2[type="text"]',
+    },
+  ]);
+});
diff --git a/packages/browser-integration-tests/suites/replay/compression/subject.js b/packages/browser-integration-tests/suites/replay/compression/subject.js
diff --git a/packages/browser-integration-tests/suites/replay/compression/test.ts b/packages/browser-integration-tests/suites/replay/compression/test.ts
@@ -5,11 +5,12 @@ import { getExpectedReplayEvent } from '../../../utils/replayEventTemplates';
 import {
   getFullRecordingSnapshots,
   getReplayEvent,
+  replayEnvelopeIsCompressed,
   shouldSkipReplayTest,
   waitForReplayRequest,
 } from '../../../utils/replayHelpers';
 
-sentryTest('replay recording should be compressed by default', async ({ getLocalTestPath, page }) => {
+sentryTest('replay recording should be compressed by default', async ({ getLocalTestPath, page, forceFlushReplay }) => {
   if (shouldSkipReplayTest()) {
     sentryTest.skip();
   }
@@ -27,10 +28,16 @@ sentryTest('replay recording should be compressed by default', async ({ getLocal
   const url = await getLocalTestPath({ testDir: __dirname });
 
   await page.goto(url);
-  const replayEvent0 = getReplayEvent(await reqPromise0);
+  await forceFlushReplay();
+
+  const req0 = await reqPromise0;
+
+  const replayEvent0 = getReplayEvent(req0);
   expect(replayEvent0).toEqual(getExpectedReplayEvent());
 
-  const snapshots = getFullRecordingSnapshots(await reqPromise0);
+  expect(replayEnvelopeIsCompressed(req0)).toEqual(true);
+
+  const snapshots = getFullRecordingSnapshots(req0);
   expect(snapshots.length).toEqual(1);
 
   const stringifiedSnapshot = JSON.stringify(snapshots[0]);

diff --git a/packages/browser-integration-tests/suites/replay/compressionDisabled/init.js b/packages/browser-integration-tests/suites/replay/compressionDisabled/init.js
@@ -0,0 +1,18 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+window.Replay = new Sentry.Replay({
+  flushMinDelay: 200,
+  flushMaxDelay: 200,
+  minReplayDuration: 0,
+  useCompression: false,
+});
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  sampleRate: 0,
+  replaysSessionSampleRate: 1.0,
+  replaysOnErrorSampleRate: 0.0,
+
+  integrations: [window.Replay],
+});
diff --git a/packages/browser-integration-tests/suites/replay/compressionDisabled/template.html b/packages/browser-integration-tests/suites/replay/compressionDisabled/template.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+  </head>
+  <body>
+    <button id="go-background">New Tab</button>
+  </body>
+</html>
diff --git a/packages/browser-integration-tests/suites/replay/compressionDisabled/test.ts b/packages/browser-integration-tests/suites/replay/compressionDisabled/test.ts
@@ -0,0 +1,52 @@
+import { expect } from '@playwright/test';
+
+import { sentryTest } from '../../../utils/fixtures';
+import { getExpectedReplayEvent } from '../../../utils/replayEventTemplates';
+import {
+  getFullRecordingSnapshots,
+  getReplayEvent,
+  replayEnvelopeIsCompressed,
+  shouldSkipReplayTest,
+  waitForReplayRequest,
+} from '../../../utils/replayHelpers';
+
+sentryTest(
+  'replay recording should allow to disable compression',
+  async ({ getLocalTestPath, page, forceFlushReplay }) => {
+    if (shouldSkipReplayTest()) {
+      sentryTest.skip();
+    }
+
+    const reqPromise0 = waitForReplayRequest(page, 0);
+
+    await page.route('https://dsn.ingest.sentry.io/**/*', route => {
+      return route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({ id: 'test-id' }),
+      });
+    });
+
+    const url = await getLocalTestPath({ testDir: __dirname });
+
+    await page.goto(url);
+    await forceFlushReplay();
+
+    const req0 = await reqPromise0;
+
+    const replayEvent0 = getReplayEvent(req0);
+    expect(replayEvent0).toEqual(getExpectedReplayEvent());
+
+    expect(replayEnvelopeIsCompressed(req0)).toEqual(false);
+
+    const snapshots = getFullRecordingSnapshots(req0);
+    expect(snapshots.length).toEqual(1);
+
+    const stringifiedSnapshot = JSON.stringify(snapshots[0]);
+    expect(stringifiedSnapshot).toContain('"tagName":"body"');
+    expect(stringifiedSnapshot).toContain('"tagName":"html"');
+    expect(stringifiedSnapshot).toContain('"tagName":"button"');
+    expect(stringifiedSnapshot).toContain('"textContent":"*** ***"');
+    expect(stringifiedSnapshot).toContain('"id":"go-background"');
+  },
+);
diff --git a/packages/browser-integration-tests/suites/replay/compressionWorkerUrl/init.js b/packages/browser-integration-tests/suites/replay/compressionWorkerUrl/init.js
@@ -0,0 +1,19 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+window.Replay = new Sentry.Replay({
+  flushMinDelay: 200,
+  flushMaxDelay: 200,
+  minReplayDuration: 0,
+  useCompression: true,
+  workerUrl: `${window.location.origin}/my-test-worker.js`,
+});
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  sampleRate: 0,
+  replaysSessionSampleRate: 1.0,
+  replaysOnErrorSampleRate: 0.0,
+
+  integrations: [window.Replay],
+});
diff --git a/packages/browser-integration-tests/suites/replay/compressionWorkerUrl/template.html b/packages/browser-integration-tests/suites/replay/compressionWorkerUrl/template.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+  </head>
+  <body>
+    <button id="go-background">New Tab</button>
+  </body>
+</html>