Remove restrictions on unit

getsentry · Apr 12, 2022 · dd9f8c8 · dd9f8c8
1 parent 605fe42
commit dd9f8c8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/packages/tracing/src/transaction.ts b/packages/tracing/src/transaction.ts
@@ -2,7 +2,6 @@ import { getCurrentHub, Hub } from '@sentry/hub';
 import {
   Event,
   Measurements,
-  MeasurementUnit,
   Transaction as TransactionInterface,
   TransactionContext,
   TransactionMetadata,
@@ -72,10 +71,10 @@ export class Transaction extends SpanClass implements TransactionInterface {
    * Set observed measurement for this transaction.
    * @param name Name of the measurement
    * @param value Value of the measurement
-   * @param unit Unit of the measurement. (Defaults to 'ms' - milliseconds)
+   * @param unit Unit of the measurement. (Defaults to an empty string)
    * @hidden
    */
-  public setMeasurement(name: string, value: number, unit: MeasurementUnit = 'ms'): void {
+  public setMeasurement(name: string, value: number, unit: string = ''): void {
     this._measurements[name] = { value, unit };
   }
 

diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts
@@ -54,7 +54,6 @@ export { Stacktrace } from './stacktrace';
 export {
   CustomSamplingContext,
   Measurements,
-  MeasurementUnit,
   SamplingContext,
   TraceparentData,
   Transaction,

diff --git a/packages/types/src/transaction.ts b/packages/types/src/transaction.ts
@@ -115,8 +115,7 @@ export interface SamplingContext extends CustomSamplingContext {
   request?: ExtractedNodeRequestData;
 }
 
-export type MeasurementUnit = 'ns' | 'ms' | 's';
-export type Measurements = Record<string, { value: number; unit: MeasurementUnit }>;
+export type Measurements = Record<string, { value: number; unit: string }>;
 
 export type TransactionSamplingMethod = 'explicitly_set' | 'client_sampler' | 'client_rate' | 'inheritance';