ref: Move node version to runtime context (#2507)

getsentry · Mar 23, 2020 · fd26d9f · fd26d9f
1 parent 124e71e
commit fd26d9f
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -62,5 +62,6 @@
   },
   "resolutions": {
     "**/agent-base": "5"
-  }
+  },
+  "version": "0.0.0"
 }
diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts
@@ -235,9 +235,12 @@ export function parseRequest(
   };
 
   if (options.version) {
-    event.extra = {
-      ...event.extra,
-      node: global.process.version,
+    event.contexts = {
+      ...event.contexts,
+      runtime: {
+        name: 'node',
+        version: global.process.version,
+      },
     };
   }
 

diff --git a/packages/node/test/handlers.test.ts b/packages/node/test/handlers.test.ts
@@ -18,6 +18,25 @@ describe('parseRequest', () => {
     },
   };
 
+  describe('parseRequest.contexts runtime', () => {
+    test('runtime name must contain node', () => {
+      const parsedRequest: Event = parseRequest({}, mockReq);
+      expect(parsedRequest.contexts.runtime.name).toEqual('node');
+    });
+
+    test('runtime version must contain current node version', () => {
+      const parsedRequest: Event = parseRequest({}, mockReq);
+      expect(parsedRequest.contexts.runtime.version).toEqual(process.version);
+    });
+
+    test('runtime disbaled by options', () => {
+      const parsedRequest: Event = parseRequest({}, mockReq, {
+        version: false,
+      });
+      expect(parsedRequest).not.toHaveProperty('contexts.runtime');
+    });
+  });
+
   describe('parseRequest.user properties', () => {
     const DEFAULT_USER_KEYS = ['id', 'username', 'email'];
     const CUSTOM_USER_KEYS = ['custom_property'];