Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to change the color of placeholder text in the feedback form #10190

Closed
KellyWalker opened this issue Jan 11, 2024 · 3 comments · Fixed by #11417
Closed

Make it possible to change the color of placeholder text in the feedback form #10190

KellyWalker opened this issue Jan 11, 2024 · 3 comments · Fixed by #11417
Assignees
@c298lee

Comments

@KellyWalker
Copy link

Problem Statement

In the Sentry.Feedback dialog, you can customize the content and appearance of most everything. However, while you can change the value of the message placeholder, it does not seem you can change the color of it.

image

Solution Brainstorm

Add a .css property to allow for changing the color of the message placeholder text

Product Area

User Feedback
@getsantry
Copy link

getsantry bot commented Jan 11, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link

getsantry bot commented Jan 12, 2024

Routing to @getsentry/product-owners-user-feedback for triage ⏲️

@bruno-garcia
Copy link
Member

Thanks for this request, we're going through prioritization of work for user feedback soon and will take this into account.

@bruno-garcia bruno-garcia transferred this issue from getsentry/sentry Jan 15, 2024
@c298lee c298lee self-assigned this Apr 3, 2024
@c298lee c298lee mentioned this issue Apr 4, 2024
Merged
c298lee added a commit that referenced this issue Apr 9, 2024
@c298lee
feat(feedback): Customize feedback placeholder text color (#11417)
db18496 
Some browsers have a default gray colour for placeholder text. Added a
color and opacity style to placeholders so that the placeholder text is
lighter than input text.

|Before|After|
|------|------|
|<img width="304" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/dc6b218c-972f-429d-a214-1891e60b69e5">|<img
width="304" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/7dbadb0d-ef52-4203-b928-b7b1253e7552">|
|<img width="326" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/f1bf87e9-fabb-439e-a10c-94a92b5a9b9f">|<img
width="326" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/93a91c23-81d3-4203-89d1-495be1380371">|

Fixes #10190
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@c298lee @cadesalaberry
feat(feedback): Customize feedback placeholder text color (getsentry#…
65b7968 
…11417)

Some browsers have a default gray colour for placeholder text. Added a
color and opacity style to placeholders so that the placeholder text is
lighter than input text.

|Before|After|
|------|------|
|<img width="304" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/dc6b218c-972f-429d-a214-1891e60b69e5">|<img
width="304" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/7dbadb0d-ef52-4203-b928-b7b1253e7552">|
|<img width="326" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/f1bf87e9-fabb-439e-a10c-94a92b5a9b9f">|<img
width="326" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/93a91c23-81d3-4203-89d1-495be1380371">|

Fixes getsentry#10190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c298lee c298lee

Labels
None yet
Projects
GitHub Issues with 👀 2
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(feedback): Customize feedback placeholder text color getsentry/sentry-javascript
5 participants
@bruno-garcia @KellyWalker @lforst @c298lee @Kobby-Bawuah