Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mongo OpenTelemetry spans don't match Sentry spans #10219

Closed
timfish opened this issue Jan 17, 2024 · 1 comment
Closed

Mongo OpenTelemetry spans don't match Sentry spans #10219

timfish opened this issue Jan 17, 2024 · 1 comment
Labels
Package: node Package-Meta: OpenTelemetry Type: Bug

Comments

@timfish
Copy link
Collaborator

timfish commented Jan 17, 2024 •
edited

Which SDK are you using?

@sentry/node-experimental

Expected Result

Spans should closely resemble Sentry spans

Actual Result

image
  • description is completely different:
    - image
  • data.db.mongodb.doc are missing
  • data.db.mongodb.query are missing
  • data.db.mongodb.filter are missing
  • data.db.mongodb.update are missing
  • data.db.operation - xxxOne becomes xxx, ie. fineOne becomes find, updateOne becomes update:
    - image
@AbhiPrasad
Copy link
Member

AbhiPrasad commented Jan 17, 2024 •
edited

I think these changes are fine - they map to https://opentelemetry.io/docs/specs/semconv/database/mongodb/. We were collecting this additional info, but they aren't being used in the product in any way atm.

Actually serializing the operations in the current way has PII issues, we should actually gate this behind sendDefaultPii - let me make the change!!

@AbhiPrasad AbhiPrasad mentioned this issue Jan 17, 2024
Merged
AbhiPrasad added a commit that referenced this issue Jan 18, 2024
@AbhiPrasad
fix(tracing): Gate mongo operation span data behind sendDefaultPii (#…
97c4e3b 
…10227)

As was raised in
#10219, we set some
extra operation based fields on span data for mongodb.

This is unfortunately just serialized output, which means it can contain
PII (it needs to be paramaterized for PII to be removed).

Given this data will change a lot when we switch to OTEL, gate setting
this specific span data behind `sendDefaultPii`.
@mydea mydea closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: node Package-Meta: OpenTelemetry Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timfish @mydea @AbhiPrasad