Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include more scope context for ANR events #10668

Closed
timfish opened this issue Feb 15, 2024 · 0 comments · Fixed by #11256
Closed

Include more scope context for ANR events #10668

timfish opened this issue Feb 15, 2024 · 0 comments · Fixed by #11256
Assignees
@timfish
Labels
Package: node Type: Improvement

Comments

@timfish
Copy link
Collaborator

timfish commented Feb 15, 2024

Problem Statement

Currently ANR events only pull the trace context from the blocked context.

Solution Brainstorm

We should also pull user, tags and extra.
@timfish timfish mentioned this issue Feb 15, 2024
Closed
3 tasks
@timfish timfish changed the title Pull more scope context for ANR events Include more scope context for ANR events Feb 15, 2024
@timfish timfish self-assigned this Feb 18, 2024
This was referenced Mar 18, 2024
Closed
Merged
AbhiPrasad pushed a commit that referenced this issue Mar 25, 2024
@timfish
feat(node): Add scope to ANR events (#11256)
693f6ca 
Closes #10668

Rather than inject large unchecked JavaScript strings to run via
`Runtime.evaluate`, when the ANR integration is enabled, we add a
function to `global.__SENTRY_GET_SCOPES__` which can then be called via
the debugger when the event loop is suspended.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@timfish @cadesalaberry
feat(node): Add scope to ANR events (getsentry#11256)
3493d11 
Closes getsentry#10668

Rather than inject large unchecked JavaScript strings to run via
`Runtime.evaluate`, when the ANR integration is enabled, we add a
function to `global.__SENTRY_GET_SCOPES__` which can then be called via
the debugger when the event loop is suspended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timfish timfish

Labels
Package: node Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(node): Add scope to ANR events getsentry/sentry-javascript
2 participants
@timfish @AbhiPrasad