Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only generate spans/transactions for remix related routes in Remix/Vite app #11105

Closed
AbhiPrasad opened this issue Mar 14, 2024 · 0 comments · Fixed by #11149
Closed

Only generate spans/transactions for remix related routes in Remix/Vite app #11105

AbhiPrasad opened this issue Mar 14, 2024 · 0 comments · Fixed by #11149
Assignees
@onurtemizkan
Labels
Package: remix Type: Improvement

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Mar 14, 2024 •
edited

Problem Statement

From Discord: https://discord.com/channels/621778831602221064/1217331440585408582

On Remix Vite app, after enabling performance monitoring, every single request triggers a new transaction, including the ones generated from external bots such as .env, info.php etc (there are like 50+)
Is it possible to track performance only to Remix relevant endpoints? (routes, loader, actions)

Solution Brainstorm

Make sure we only instrument remix-related endpoints by default.
@onurtemizkan onurtemizkan mentioned this issue Mar 17, 2024
Merged
AbhiPrasad pushed a commit that referenced this issue Apr 8, 2024
@onurtemizkan
feat(remix): Skip span creation for OPTIONS and HEAD requests. (#…
f7db230 
…11149)

Fixes: #11105

Skips span creation for `OPTIONS` and `HEAD` requests in
`wrapRequestHandler`, which apparently are the unwanted requests
mentioned in #11105. We can also implement a more precise filtering but
this seems to resolve it on my local test application.
onurtemizkan added a commit that referenced this issue Apr 8, 2024
@onurtemizkan
feat(remix): Skip span creation for OPTIONS and HEAD requests. (#…
85408af 
…11149)

Fixes: #11105

Skips span creation for `OPTIONS` and `HEAD` requests in
`wrapRequestHandler`, which apparently are the unwanted requests
mentioned in #11105. We can also implement a more precise filtering but
this seems to resolve it on my local test application.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@onurtemizkan @cadesalaberry
feat(remix): Skip span creation for OPTIONS and HEAD requests. (g…
661f9cc 
…etsentry#11149)

Fixes: getsentry#11105

Skips span creation for `OPTIONS` and `HEAD` requests in
`wrapRequestHandler`, which apparently are the unwanted requests
mentioned in getsentry#11105. We can also implement a more precise filtering but
this seems to resolve it on my local test application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onurtemizkan onurtemizkan

Labels
Package: remix Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(remix): Skip span creation for OPTIONS and HEAD requests. getsentry/sentry-javascript
2 participants
@onurtemizkan @AbhiPrasad