Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React 19 peer dep #12200

Closed
osdiab opened this issue May 24, 2024 · 2 comments · Fixed by #12207
Closed

Add React 19 peer dep #12200

osdiab opened this issue May 24, 2024 · 2 comments · Fixed by #12207
Assignees
Labels
Package: react Issues related to the Sentry React SDK Type: Improvement

Comments

@osdiab
Copy link

osdiab commented May 24, 2024

Problem Statement

NextJS 15 RC was just released, it depends on React 19, would like to upgrade but getting peer dependency issues.

Solution Brainstorm

Not sure if any code changes are needed for Sentry to work properly, but simplest is to update the peer dependency versions for react and react-dom to permit ^19.

@Lms24
Copy link
Member

Lms24 commented May 24, 2024

Hey @osdiab thanks for writing in!

We're currently working on React 19 support which is tracked in #11798. Once this is stable, we can also bump the respective peer dependencies in the NextJS SDK as well. Pleaes not though, that we generally only bump peer deps once the new major is stable (as opposed to RC or preview).

@AbhiPrasad AbhiPrasad added the Package: react Issues related to the Sentry React SDK label May 24, 2024
@AbhiPrasad
Copy link
Member

I think we can bump the peer dep for React right now considering I've tested it quite a bit already and everything seems to be fine. #12147 is a new feature, so we shouldn't block on it.

#12207

I won't bump Next.js peer dep though because we have to do a lot more testing for Next.js 15.

@AbhiPrasad AbhiPrasad self-assigned this May 24, 2024
AbhiPrasad added a commit that referenced this issue May 24, 2024
Closes #12200

From my personal testing everything works with with React 19, so we can
bump the peer dep.

For the new error APIs, there is
#12147, but that PR
is draft while we get feedback from the React team.
@AbhiPrasad AbhiPrasad changed the title React 19 support Add React 19 peer dep May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react Issues related to the Sentry React SDK Type: Improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants