Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User Feedback] Screenshot quality is low after cropping #12329

Closed
c298lee opened this issue Jun 3, 2024 · 0 comments · Fixed by #12487
Closed

[User Feedback] Screenshot quality is low after cropping #12329

c298lee opened this issue Jun 3, 2024 · 0 comments · Fixed by #12487
Assignees
@c298lee

Comments

@c298lee
Copy link
Member

c298lee commented Jun 3, 2024

After cropping, the screenshot zooms in and the quality is too low to read the text

Screenshot 2024-05-10 at 1 06 04 PM
@c298lee c298lee changed the title [User Feedback]: Screenshot quality is low after cropping [User Feedback] Screenshot quality is low after cropping Jun 3, 2024
@c298lee c298lee self-assigned this Jun 12, 2024
@c298lee c298lee mentioned this issue Jun 12, 2024
Merged
c298lee added a commit that referenced this issue Jun 13, 2024
@c298lee
feat(feedback): Screenshots don't resize after cropping (#12481)
d94695d 
Screenshots will no longer become larger to fit the screenshot area
after being cropped, instead it would remain the same size. The image
quality of the screenshot goes down if the image is cropped too much.
This could help make small crops a bit more readable.
Before:
<img width="1716" alt="Select a speeder"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/c99af75e-4cfc-41e2-86bc-f0232962f91a">
After:
<img width="1716" alt="Pasted Graphic"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/1bd2b1ef-ef8c-4b6d-90fa-ae444141ede0">
Relates to #12329
@c298lee c298lee mentioned this issue Jun 14, 2024
Merged
c298lee added a commit that referenced this issue Jun 17, 2024
@c298lee @billyvg
feat(feedback): Improve screenshot quality for retina displays (#12487)
fdad379 
Improves screenshot quality after cropping for retina displays. This
increases resolution after cropping by factoring in DPI.
Before:
<img width="974" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/e39397ae-8c6c-47a6-8d10-260c16eb8234">

After:
<img width="974" alt="image"
src="https://github.com/getsentry/sentry-javascript/assets/55311782/bd05b88b-3d2f-4193-b55b-75aae0bba8b9">

The size is the same when cropping but when viewing feedbacks,
screenshots from retina displays are twice as large due to higher DPI.

Closes #12329

---------

Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c298lee c298lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(feedback): Improve screenshot quality for retina displays getsentry/sentry-javascript
1 participant
@c298lee