@sentry/ember throws exception when handling rootURLs

[jonchay]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other: @sentry/ember

Version:

5.26.0

Description

I'm using @sentry/ember package, in our Ember application we specify a rootURL for our ember application to host on that specific path (e.g. https://www.domain.com/ember-app/)

When we ran the application an error throws from sentry-performance from this line:

Error: Assertion Failed: You must pass a url that begins with the application's rootURL "/ember-app/"

But the url it was handling is /. If I'm not mistaken, when we pass a url to routerService.recognize we have to prefix with the rootURL.

[netes]

I stumbled upon the same problem today. Is there any ETA for fixing this?

[patrickberkeley]

Came across this issue today as well.

[theklr]

Ditto as an issue

[jonchay]

Hello, just want to follow-up if there is any resolution to this issue?

[Gorzas]

I still have the problem with the last fix. Shouldn't the code concat the rootURL? Like:

  let url = location && location.getURL && location.formatURL && location.formatURL(location.getURL());
  url = `${location.rootURL}${url}`;

[k-fish]

@Gorzas what kind of location do you have? (auto, hash etc.), I can test it out if you give me an example. When I checked the source, formatURL should be adding rootURL already (see: https://github.com/emberjs/ember.js/blob/b9c974c7f7fe086deb8a5ec0150f7c1877dfdb9b/packages/%40ember/-internals/routing/lib/location/history_location.ts#L251)

[Gorzas]

@k-fish I'm using hash, so it uses hash_location instead of history_location. You can see the difference: https://github.com/emberjs/ember.js/blob/v3.24.0/packages/%40ember/-internals/routing/lib/location/hash_location.ts#L153-L155

[k-fish]

@Gorzas ah yeah, hash locations don't append the root in their formatURL. I put up a special case for hash locations and tried it out on the addon's dummy application, it should work once #3195 goes in.

[Gorzas]

Thanks @k-fish! Is there a way so I can test the solution? I don't know how to install from an specific commit in a monorepo.

[k-fish]

@Gorzas if you'd like to test it out that'd be great! It's been a while since I've done it from scratch, but using the monorepo should be pretty much identical to testing a regular local package, with an extra step or two.

In the monorepo directory:

• yarn run build (build the local and supporting packages)
• yarn run link:yarn (makes the packages available for linking)

In your app directory:

• ember install @sentry/ember (if you haven't already)
• yarn link @sentry/ember

If you run into an error when starting the server about mismatching versions, just make sure your applications package.json has the latest version and it matches the monorepo's version (I just pushed the new version, so they should be both 6.0.2)

[Gorzas]

@k-fish it's working now. Thanks a lot! 👍