feat(browser): Add new v7 Fetch Transport #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
commented
Mar 24, 2022
packages/core/src/request.ts
Outdated
| // 2. Restore the original version of the request body, which is commented out | ||
| // 3. Search for either of the PR URLs above and pull out the companion hacks in the browser playwright tests and the | ||
| // baseClient tests in this package | ||
| enhanceEventWithSdkInfo(event, api.metadata.sdk); |
There was a problem hiding this comment.
not nice to duplicate all of this, but considering we are deleting stuff very soon, I think duplicating this code is fine.
size-limit report 📦
|
|
ouch size-limit bot |
|
Opened #4778 with some changes from this PR |
|
So it seems this is failing on the minified bundles 🤔 |
|
So in regular bundles it works fine ( @onurtemizkan any idea why this might be happening? |
@AbhiPrasad, that's very strange, there aren't any special cases for minified bundles, while building pages. |
|
Figured it out, it's because the minified bundle minifies the |
Lms24
added a commit
that referenced
this pull request
Mar 29, 2022
* add the new XHR Transport creation functionality. The function makeNewXHRTransport(...) creates a Transport that is based on the browser's XMLHttpRequest API. It is used as a fallback if the Fetch API is not available (IE11...). The creation function is similar to the new Fetch Transport creation introduced in #4765. * in addition to the transport creation function, this PR also adds tests which verify the correct calls to the XMLHttpRequest API. Furthermore, the tests check for correct request/response header setting.
lforst
pushed a commit
that referenced
this pull request
Mar 29, 2022
* add the new XHR Transport creation functionality. The function makeNewXHRTransport(...) creates a Transport that is based on the browser's XMLHttpRequest API. It is used as a fallback if the Fetch API is not available (IE11...). The creation function is similar to the new Fetch Transport creation introduced in #4765. * in addition to the transport creation function, this PR also adds tests which verify the correct calls to the XMLHttpRequest API. Furthermore, the tests check for correct request/response header setting.
lforst
pushed a commit
that referenced
this pull request
Mar 29, 2022
This PR creates the new v7 Fetch Transport, and updates the browser backend to use the new transport. To configure the transport, users can supply `requestOptions`, which is supplied to the fetch request. This consolidates the earlier pattern of passing in both headers and fetchParameters that the old fetch transport used to use.
lforst
pushed a commit
that referenced
this pull request
Mar 29, 2022
* add the new XHR Transport creation functionality. The function makeNewXHRTransport(...) creates a Transport that is based on the browser's XMLHttpRequest API. It is used as a fallback if the Fetch API is not available (IE11...). The creation function is similar to the new Fetch Transport creation introduced in #4765. * in addition to the transport creation function, this PR also adds tests which verify the correct calls to the XMLHttpRequest API. Furthermore, the tests check for correct request/response header setting.
Lms24
added a commit
that referenced
this pull request
Mar 29, 2022
add integration tests to test the new XHR transport introduced in #4803 * the tests are very similar to the new Fetch transport integration tests introduced in #4765. The only difference is that they disable the browsers' Fetch API by setting window.fetch = undefined. This way, the SDK falls back to the XHR transport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the new v7 Fetch Transport, and updates the browser backend to use the new transport. To configure the transport, users can supply
requestOptions, which is supplied to the fetch request. This consolidates the earlier pattern of passing in both headers and fetchParameters that the old fetch transport used to use.Part of #4660
Resolves https://getsentry.atlassian.net/browse/WEB-726