feat(browser): Add new v7 XHR Transport #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
force-pushed
the
lms-new-xhr-transport
branch
from
db1dcd4
to
57a06f4
Compare
|
CI should pass once #4810 is done and merged (the errors seem to be related to MongoDB) |
Lms24
commented
Mar 29, 2022
| const XHR_READYSTATE_DONE = 4; | ||
|
|
||
| export interface XHRTransportOptions extends BaseTransportOptions { | ||
| headers?: { [key: string]: string }; |
There was a problem hiding this comment.
Decided to go with {[key: string]: string} instead of Record as it is used that way in TransportOptions
sentry-javascript/packages/types/src/transport.ts
Lines 52 to 56 in caba96e
which are passed to makeNewXHRTransport. Seems to be more consistent that way IMHO
add makeNewXHRTransport function (WIP, needs testing(
Lms24
force-pushed
the
lms-new-xhr-transport
branch
from
1224b1d
to
4672d15
Compare
AbhiPrasad
approved these changes
Mar 29, 2022
lforst
pushed a commit
that referenced
this pull request
Mar 29, 2022
* add the new XHR Transport creation functionality. The function makeNewXHRTransport(...) creates a Transport that is based on the browser's XMLHttpRequest API. It is used as a fallback if the Fetch API is not available (IE11...). The creation function is similar to the new Fetch Transport creation introduced in #4765. * in addition to the transport creation function, this PR also adds tests which verify the correct calls to the XMLHttpRequest API. Furthermore, the tests check for correct request/response header setting.
lforst
pushed a commit
that referenced
this pull request
Mar 29, 2022
* add the new XHR Transport creation functionality. The function makeNewXHRTransport(...) creates a Transport that is based on the browser's XMLHttpRequest API. It is used as a fallback if the Fetch API is not available (IE11...). The creation function is similar to the new Fetch Transport creation introduced in #4765. * in addition to the transport creation function, this PR also adds tests which verify the correct calls to the XMLHttpRequest API. Furthermore, the tests check for correct request/response header setting.
Lms24
added a commit
that referenced
this pull request
Mar 29, 2022
add integration tests to test the new XHR transport introduced in #4803 * the tests are very similar to the new Fetch transport integration tests introduced in #4765. The only difference is that they disable the browsers' Fetch API by setting window.fetch = undefined. This way, the SDK falls back to the XHR transport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new XHR Transport creation functionality. The function
makeNewXHRTransport(...)creates a Transport that is based on the browser'sXMLHttpRequestAPI. It is used as a fallback if the Fetch API is not available (IE11...). The creation function is similar to the new Fetch Transport creation introduced in #4765.In addition to the transport creation function, this PR also adds tests which verify the correct calls to the
XMLHttpRequestAPI. Furthermore, the tests check for correct request/response header setting. Note that I didn't include integration tests for this change as I did not yet find a way to "deactivate" the Fetch API in our playwright test framework. If I figured out a way to do this, Integration tests will follow in a separate PR.ref: https://getsentry.atlassian.net/browse/WEB-727