fix(test): Fix MongoDB integration tests on CI. #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Mar 28, 2022
| @@ -2,6 +2,9 @@ import { MongoMemoryServer } from 'mongodb-memory-server'; | |||
|
|
|||
| import { assertSentryTransaction, getEnvelopeRequest, runServer } from '../../../../utils'; | |||
|
|
|||
| // mongodb-memory-server may download a MongoDB binary in different Node versions | |||
There was a problem hiding this comment.
which node versions does this apply to?
There was a problem hiding this comment.
Thought it was just 16, but it looks like it installs for 12, 14 and 16. Maybe it's better to move this out to pre-test.
There was a problem hiding this comment.
Maybe it's better to move this out to pre-test.
I think thats a good idea
size-limit report 📦
|
AbhiPrasad
reviewed
Mar 28, 2022
|
|
||
| const NODE_VERSION = parseSemver(process.versions.node); | ||
|
|
||
| // Skipping on Node versions below 12 as `mongo-memory-server` |
There was a problem hiding this comment.
Need to finish this comment?
AbhiPrasad
reviewed
Mar 28, 2022
| process.env.MONGO_URL = mongoServer.getUri(); | ||
| }, 30000); | ||
| // Skipping on Node versions below 12 as `mongo-memory-server` supports >= 12 | ||
| const conditionalTest = NODE_VERSION.major && NODE_VERSION.major < 12 ? describe.skip : describe; |
There was a problem hiding this comment.
Let’s extract this into a helper, turn it into a function, and give the node version as the function argument. That way we can re-use this in other places.
AbhiPrasad
approved these changes
Mar 29, 2022
lforst
pushed a commit
that referenced
this pull request
Mar 29, 2022
lforst
pushed a commit
that referenced
this pull request
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conditionalTesthelper to skip tests depending on node versions.mongodb-memory-serverto version 7