Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Stack trace link to URL picking up trailing parenthesis #5459

Closed
mwarkentin opened this issue Jul 19, 2022 · 6 comments · Fixed by #5522
Closed

Bug: Stack trace link to URL picking up trailing parenthesis #5459

mwarkentin opened this issue Jul 19, 2022 · 6 comments · Fixed by #5522
Labels
Package: browser Issues related to the Sentry Browser SDK

Comments

@mwarkentin
Copy link
Member

Environment

SaaS (https://sentry.io/)

Version

No response

Steps to Reproduce

Trigger an exception which includes a URL like:

Loading chunk app_bootstrap_initializeLocale_tsx failed.
(error: https://s1.sentry-cdn.com/_static/dist/sentry/chunks/app_bootstrap_initializeLocale_tsx.cb92d261ee5cdae6468b.js)

Here's an example.

Expected Result

After removing the ) the URL works:

image

When detecting URLs maybe we can trim special characters from the end?

Actual Result

The URL which is extracted in the stack trace will include the trailing parenthesis:

image

image

@priscilawebdev
Copy link
Member

thanks for the heads up @mwarkentin we have added this issue to our backlog

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Jul 25, 2022

We need to adjust the stacktrace parsing regex to fix this! Transferring to the JS SDK as a result.

Tracking JIRA: https://getsentry.atlassian.net/browse/TET-245

@AbhiPrasad AbhiPrasad transferred this issue from getsentry/sentry Jul 25, 2022
@AbhiPrasad AbhiPrasad added Package: browser Issues related to the Sentry Browser SDK and removed Scope: Frontend labels Jul 25, 2022
@AbhiPrasad
Copy link
Member

AbhiPrasad commented Jul 25, 2022

The raw chrome stacktrace (id's removed to obfiscate):

ChunkLoadError: Loading chunk app_bootstrap_initializeLocale_tsx failed.
(error: https://s1.sentry-cdn.com/_static/dist/sentry/chunks/app_bootstrap_initializeLocale_tsx.abcdefg.js)
  at (error: (/_static/dist/sentry/chunks/app_bootstrap_initializeLocale_tsx.abcdefg.js))
  at key(webpack/runtime/jsonp chunk loading:27:18)
  at ? (webpack/runtime/ensure chunk:6:25)
  at Array.reduce(<anonymous>)
  at Function._.e(webpack/runtime/ensure chunk:5:56)
  at gsApp(../../getsentry/static/getsentry/gsApp/index.tsx:17:7)
  at ? (../../getsentry/static/getsentry/gsApp/index.tsx:49:1)
  at ? (dist/sentry/sourcemaps/app.abcdefg.js:49:1)
  at ? (dist/sentry/sourcemaps/app.abcdefg.js:49:1)

@lobsterkatie
Copy link
Member

lobsterkatie commented Jul 25, 2022

related:
#5151
#4138
#5498

@timfish
Copy link
Collaborator

timfish commented Aug 3, 2022

This stack trace is wild!

Even if I can get the regex to parse this line, the path is relative to https://s1.sentry-cdn.com/ and since ours is a line parser, we have no access to the previous line. This path is then going to look like it's part of the app!
at (error: (/_static/dist/sentry/chunks/app_bootstrap_initializeLocale_tsx.abcdefg.js))

Also, no column or line numbers, so is this even a proper frame?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: browser Issues related to the Sentry Browser SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants