Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stacktrace parsing] Regex incorrectly truncating filenames with colons #5151

Closed
lobsterkatie opened this issue May 23, 2022 · 0 comments · Fixed by #5517
Closed

[stacktrace parsing] Regex incorrectly truncating filenames with colons #5151

lobsterkatie opened this issue May 23, 2022 · 0 comments · Fixed by #5517
Labels
Meta: Help Wanted Package: node Issues related to the Sentry Node SDK Type: Bug

Comments

@lobsterkatie
Copy link
Member

A customer reports that they have filenames with times in them (like /releases/2022-05-16T11:27:37.760Z/app.js), which are getting truncated at the first colon. Our regex here likely just needs to be updated to handle this case.

This is showing up in @sentry/node 6.19.7.
daniellockyer added a commit to TryGhost/Deploy that referenced this issue Jul 4, 2022
@daniellockyer
Fixed colons and periods in filenames
324438e 
refs getsentry/sentry-javascript#5151

- this works around the above issue by replacing colons and periods with
  an underscore
@lobsterkatie lobsterkatie mentioned this issue Jul 25, 2022
Closed
@lobsterkatie lobsterkatie mentioned this issue Aug 1, 2022
Closed
@timfish timfish mentioned this issue Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Meta: Help Wanted Package: node Issues related to the Sentry Node SDK Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(node): Handle colons in stack trace paths timfish/sentry-javascript
2 participants
@lobsterkatie @AbhiPrasad