Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte SDK Alpha 2.0 Release #5573

Closed
6 tasks done
Lms24 opened this issue Aug 12, 2022 · 1 comment
Closed
6 tasks done

Svelte SDK Alpha 2.0 Release #5573

Lms24 opened this issue Aug 12, 2022 · 1 comment
Assignees
@Lms24
Labels
Package: svelte Issues related to the Sentry Svelte SDK
Milestone
Svelte SDK

Comments

@Lms24
Copy link
Member

Lms24 commented Aug 12, 2022 •
edited
Loading

Tracking To Do items for the second alpha release of the Svelte SDK

ref: #5492
@Lms24 Lms24 mentioned this issue Aug 12, 2022
Closed
8 tasks
@Lms24 Lms24 changed the title Add component tracking performance monitoring features Svelte SDK Alpha 2.0 Aug 12, 2022
@Lms24 Lms24 changed the title Svelte SDK Alpha 2.0 Svelte SDK Alpha Release 2.0 Aug 12, 2022
@Lms24 Lms24 self-assigned this Aug 12, 2022
@Lms24 Lms24 added the Package: svelte Issues related to the Sentry Svelte SDK label Aug 12, 2022
@Lms24 Lms24 added this to the Svelte SDK milestone Aug 12, 2022
This was referenced Aug 12, 2022
Merged
Merged
@vladanpaunovic vladanpaunovic changed the title Svelte SDK Alpha Release 2.0 Svelte SDK Alpha 2.0 Release Aug 12, 2022
@Lms24 Lms24 mentioned this issue Aug 17, 2022
Merged
timfish pushed a commit to timfish/sentry-javascript that referenced this issue Aug 22, 2022
@Lms24
chore(svelte): Detect and report SvelteKit usage (getsentry#5594)
74db527 
Add a SvelteKit detection mechanism to our SDK and inserts a SvelteKit entry into `event.modules` if we detect that the frontend in which the SDK is used, was rendered by SvelteKit.

To check this, we check for the existence of a div with the id `svelte-announcer` that's automatically injected into the rendered HTML by SvelteKit. It is used to improve accessibility (see sveltejs/kit#307) but we can leverage it as a SvelteKit detection criterion. 

Btw, we're not the first ones who came up with this approach, as it turns out: https://twitter.com/jhewt/status/1359632380483493889 

Introduce a new utils function, `getDomElement` in which we consolidate the usage of `document.querySelector` in the SDK. So in addition to using this new function for obtaining the div described above, we now also call it in `BrowserTracing` to get `<meta>` tags.

Add some tests to test the new behaviour and the helper functions. We might want to consider writing an integration test for this feature but this first requires a Svelte SDK integration test infrastructure. 

ref: getsentry#5573
@Lms24 Lms24 mentioned this issue Aug 31, 2022
Merged
@Lms24
Copy link
Member Author

Lms24 commented Sep 1, 2022

We released the second alpha version of the Svelte SDK with version 7.12.0.
I'll close this issue and make a new one for the beta release 🚀

@Lms24 Lms24 closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lms24 Lms24

Labels
Package: svelte Issues related to the Sentry Svelte SDK
Projects
None yet
Milestone
Svelte SDK
Development

No branches or pull requests
1 participant
@Lms24