-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text to elements in breadcrumbs ui.click #577
Comments
So, this is something I'd like to do, but I'm concerned about bloating our DOM serializing function to the point that it begins to add noticeable overhead to click handlers. But, I will explore. |
One easy alternative could be to just do
that will output the element clicked exactly as is. You'll loose the tree structure - but in my personal experience that doesn't help as much as seeing the full, actual element that I'm used to seeing in my code all the time and therefore more quickly can recognize. That would solve #576 as well |
@soroushhakami – we started with The reason we didn't go with
Basically, |
Ah I see, makes sense, thanks for the explanation! 👍 |
I've added ID tags to all my buttons. Surprised that they don't show up in the breadcrumbs. Even if it was a custom tag, I'd be happy with it. But ID tag seems to be ideal due to its uniqueness. |
@nblasgen – if you can provide a failing test case, I'd be glad to look at what's up. But right now the code is supposed to capture IDs, and there is a test that verifies this. |
+1 for showing ID's, or a custom tag like |
@kamilogorek any updates on this? Is there a possibility to fine-tune click "message"? Maybe, more data can be passed into |
@TuxujPes it'll be possible in the next major release, however not in this one, as it requires some public API changes that we can only introduce in major releases. |
@kamilogorek that sounds great. Any estimations on major release date? |
Somewhere near the end of Q3 (excuse me such a long response time, was on vacations). |
They could analyze if there is this information and take it along. If it exists, leave the selectors with a button for more information. |
@hiagodotme @TuxujPes @adamreisnz this feature is already available in new SDK - https://docs.sentry.io/learn/filtering/?platform=javascript#before-breadcrumb |
FYI: just don't forget that using new SDK brings you +50Kb for the bundle size #1552 |
@kamilogorek I'm a bit afraid of PRs with more than 200 changes files, this seems more like a completely new SDK rather than a new version. Also, what's the ETA release date of it? |
It'd make things easier especially for apps where the classnames don't reveal much.
Something along the lines of :
If the element contains alot of text, it could be truncated.
The text was updated successfully, but these errors were encountered: