Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio captured and played during replay videos #6602

Closed
jas-kas opened this issue Dec 21, 2022 · 6 comments
Closed

Audio captured and played during replay videos #6602

jas-kas opened this issue Dec 21, 2022 · 6 comments
Assignees
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Bug

Comments

@jas-kas
Copy link
Member

jas-kas commented Dec 21, 2022

Problem:

We currently are capturing audio on some replay videos for an unknown reason.

Private Jira ticket with customer details and replay example.

Solution Brainstorm:

TBD.

@jas-kas jas-kas added Status: Backlog Package: replay Issues related to the Sentry Replay SDK labels Dec 21, 2022
@billyvg
Copy link
Member

billyvg commented Dec 22, 2022

User had blockAllMedia turned off, so it's expected that video's were captured. The video has autoplay attribute on the video, so it immediately starts playing.

Let's de-prioritize this ticket as capturing <video> with autoplay enabled is an edge case. We should reword the ticket to handle <video> w/ autoplay in a better manner during playback.

for example, we should not autoplay videos, and instead only play when replay is playing. (also consider, what do we do if you pause the replay?)

@bruno-garcia
Copy link
Member

@ryan953 also mentioned:

i think the video stops playing on it’s own after a while (in chrome). the dom says that it should keep playing so it does
i think the customer should change their

@Lms24
Copy link
Member

Lms24 commented Jan 3, 2023

@bruno-garcia @billyvg is there something we should do here on the SDK side? Also, should this be downgraded to a p2?

@billyvg
Copy link
Member

billyvg commented Feb 15, 2023

On SDK side, we may want to strip autoplay when recording

@billyvg billyvg changed the title Bug: Audio captured and played during replay videos Audio captured and played during replay videos Feb 15, 2023
@bruno-garcia
Copy link
Member

bruno-garcia commented Feb 21, 2023

After discussing with the team we decided to remove the autoplay from video tags as we don't expect users will need to listen to any audio, since the video anyway won't be in sync. Audio listening something needed to help developers debug their site.

@mydea
Copy link
Member

mydea commented Feb 28, 2023

This should be removed in 7.39.0!

@mydea mydea closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Bug
Projects
None yet
Development

No branches or pull requests

5 participants