Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Replay] Long duration replays with replay type: error #6720

Closed
billyvg opened this issue Jan 10, 2023 · 0 comments · Fixed by #6722
Closed

[Replay] Long duration replays with replay type: error #6720

billyvg opened this issue Jan 10, 2023 · 0 comments · Fixed by #6722
Assignees
@billyvg
Labels
Package: replay

Comments

@billyvg
Copy link
Member

billyvg commented Jan 10, 2023 •
edited

We have a replay here with duration > 3 hrs. This is caused because we have some stale events that are being sent. And our UI code is computing the duration by taking the min + max timestamps in the recording events itself.
@billyvg billyvg self-assigned this Jan 10, 2023
@billyvg billyvg changed the title [Replay] Buffer is not flushed when session is paused and then resumed [Replay] Long duration replays with replay type: error Jan 10, 2023
@billyvg billyvg mentioned this issue Jan 10, 2023
Merged
billyvg added a commit that referenced this issue Jan 10, 2023
@billyvg
fix(replay): Fix checkoutEveryNms
daa8917 
This was inadvertantly changed and was causing replays to have very long durations since it was waiting for 60k events before resetting buffer.

Fixes #6720
billyvg added a commit that referenced this issue Jan 11, 2023
@billyvg
fix(replay): Fix checkoutEveryNms
3cae215 
This was inadvertantly changed and was causing replays to have very long durations since it was waiting for 60k events before resetting buffer.

Fixes #6720
billyvg added a commit that referenced this issue Jan 11, 2023
@billyvg
fix(replay): Fix checkoutEveryNms (#6722)
b250f9f 
This was inadvertantly changed and was causing replays to have very long durations since it was waiting for 60k events before resetting buffer.

Fixes #6720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billyvg billyvg

Labels
Package: replay
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(replay): Fix checkoutEveryNms getsentry/sentry-javascript
1 participant
@billyvg