Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Fix checkoutEveryNms #6722

Merged
merged 1 commit into from Jan 11, 2023
Merged

fix(replay): Fix checkoutEveryNms #6722

merged 1 commit into from Jan 11, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jan 10, 2023 •
edited

This was inadvertantly changed and was causing replays to have very long durations since it was waiting for 60k events before resetting buffer.

Closes #6720

@billyvg billyvg requested a review from mydea January 10, 2023 22:04
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.04 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.25 KB (0%)

mydea
mydea approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, very good catch, thank you!

@billyvg
fix(replay): Fix checkoutEveryNms
3cae215 
This was inadvertantly changed and was causing replays to have very long durations since it was waiting for 60k events before resetting buffer.

Fixes #6720
@billyvg billyvg force-pushed the fix-replay-clear-buffer-resuming-session branch from daa8917 to 3cae215 Compare January 11, 2023 14:40
@billyvg billyvg enabled auto-merge (squash) January 11, 2023 14:40
@billyvg billyvg merged commit b250f9f into master Jan 11, 2023
@billyvg billyvg deleted the fix-replay-clear-buffer-resuming-session branch January 11, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Replay] Long duration replays with replay type: error
3 participants
@billyvg @mydea @Lms24