Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deprecated Replay session and error sample rates #6958

Closed
Tracked by #9508
Lms24 opened this issue Jan 27, 2023 · 0 comments · Fixed by #11045
Closed
Tracked by #9508

Delete deprecated Replay session and error sample rates #6958

Lms24 opened this issue Jan 27, 2023 · 0 comments · Fixed by #11045
Assignees
@s1gr1d
Labels
Meta: Breaking Package: replay Issues related to the Sentry Replay SDK Type: Improvement
Milestone
8.0.0

Comments

@Lms24
Copy link
Member

Lms24 commented Jan 27, 2023

Problem Statement

Before GA we're going to remove the already deprecated session and error sample rates for Replay that previously could be passed into the Replay integration's init options.

Solution Brainstorm

We'll remove these options, get rid of the code that merges them with the top-level init options, remove the warnings and add a note in the migration guide.
@Lms24 Lms24 added Type: Improvement Package: replay Issues related to the Sentry Replay SDK labels Jan 27, 2023
@Lms24 Lms24 changed the title Delete deprecated session and error sample rates Delete deprecated Replay session and error sample rates Jan 27, 2023
@HazAT HazAT added this to the 8.0.0 milestone Feb 20, 2023
@mydea mydea mentioned this issue Nov 9, 2023
Closed
@s1gr1d s1gr1d self-assigned this Mar 6, 2024
@s1gr1d s1gr1d mentioned this issue Mar 12, 2024
Merged
s1gr1d added a commit that referenced this issue Mar 12, 2024
@s1gr1d
feat(replay/v8): Delete deprecated replaySession and `errorSampleRa…
c3447d0 
…tes` (#11045)

Options can be configured with `replaysSessionSampleRate` and
`replaysOnErrorSampleRate`.
closes #6958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1gr1d s1gr1d

Labels
Meta: Breaking Package: replay Issues related to the Sentry Replay SDK Type: Improvement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

feat(replay/v8): Delete deprecated replaySession and errorSampleRates getsentry/sentry-javascript
4 participants
@HazAT @Lms24 @hubertdeng123 @s1gr1d