fix(integrations): BaseClient reports integrations added after init

[krystofwoldrich]

In RN SDK we would like to add some integrations using the client.addIntegration method, but these integrations are not being reported in the event.sdk.integrations.

I assume that was not intentional.

• context: feat(internal): Add routing instrumentations report in integrations sentry-react-native#2798

[mydea]

Yes, def. not intentional! Thanks for finding & fixing this 🎉

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified)	19.91 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)	61.72 KB (+0.24% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)	18.59 KB (+0.26% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)	55.02 KB (+0.26% 🔺)
@sentry/browser - Webpack (gzipped + minified)	20.32 KB (+0.14% 🔺)
@sentry/browser - Webpack (minified)	66.48 KB (+0.17% 🔺)
@sentry/react - Webpack (gzipped + minified)	20.35 KB (+0.16% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)	47.64 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)	26.82 KB (+0.1% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)	25.12 KB (+0.17% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)	44.21 KB (+0.12% 🔺)
@sentry/replay - Webpack (gzipped + minified)	38.93 KB (+0.12% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)	61.57 KB (+0.12% 🔺)

[Lms24]

Good catch, thanks!

[krystofwoldrich]

@Lms24 @mydea I've noticed a slight problem, should I use the installedIntegrations or client._integrations as when a client gets refreshed these won't match.

I'll just reset the installedIntegrations in the tests.

[krystofwoldrich]

How do you debug these?
https://github.com/getsentry/sentry-javascript/actions/runs/4063851636/jobs/6996721341
I've run it locally and it passes, but I guess I've missed something.

[krystofwoldrich]

Still need to wait for the CI, but should be fixed now.

It's not pretty but it works. Maybe in the future when we decide to remove installedIntegrations we can talk about adding getIntegrations to Client API?

[Lms24]

It's not pretty but it works. Maybe in the future when we decide to remove installedIntegrations we can talk about adding getIntegrations to Client API?

Yes, definitely in favour of that. However, adding methods to the client is a breaking change, so we could only do it with an optional method at this time or only do it in v8. Tracking the removal in #7028

[Lms24]

I'm gonna merge this in as we're cutting a release.