Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Replay Playwright Integration Tests #7044

Closed
14 tasks done
Lms24 opened this issue Feb 2, 2023 · 0 comments
Closed
14 tasks done

Improve Replay Playwright Integration Tests #7044

Lms24 opened this issue Feb 2, 2023 · 0 comments

Comments

@Lms24
Copy link
Member

Lms24 commented Feb 2, 2023

Problem Statement

Right now, our Playwright integration tests for Replay only cover some simple scenarios without checking recording data too carefully. Due to some bugs/regressions in the past we want to spend some time to ensure these regressions don't keep happening. Due to the fact that our Playwright integration tests are already set up for Replay and they also test against CDN bundles, we want to improve them and add more test cases to ensure better fault detection capability going forward.

Solution Brainstorm

Test setup

Tasks

@Lms24 Lms24 self-assigned this Feb 2, 2023
@Lms24 Lms24 assigned mydea and unassigned Lms24 Feb 27, 2023
Lms24 added a commit that referenced this issue Feb 28, 2023
A newly added replay test (#7044) for checking for the presence of XHR/fetch request spans was flaky on CI. This was caused by two reasons:

1. We didn't explicitly await for the fetch/xhr requests to finish before waiting for the replay event which we expected to contain the span. With this fix we now wait that the browser actually received the response.
2. The tests were only flaky on Firefox. After some research (this seems to be somewhat of a [known problem](microsoft/playwright#11390 (comment)) in some situations) I decided to simply skip for FF. I think this is reasonably pragmatic as we're still testing on Chromium and Webkit.
@mydea mydea closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants