You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, our Playwright integration tests for Replay only cover some simple scenarios without checking recording data too carefully. Due to some bugs/regressions in the past we want to spend some time to ensure these regressions don't keep happening. Due to the fact that our Playwright integration tests are already set up for Replay and they also test against CDN bundles, we want to improve them and add more test cases to ensure better fault detection capability going forward.
Solution Brainstorm
The content you are editing has changed. Please copy your edits and refresh the page.
A newly added replay test (#7044) for checking for the presence of XHR/fetch request spans was flaky on CI. This was caused by two reasons:
1. We didn't explicitly await for the fetch/xhr requests to finish before waiting for the replay event which we expected to contain the span. With this fix we now wait that the browser actually received the response.
2. The tests were only flaky on Firefox. After some research (this seems to be somewhat of a [known problem](microsoft/playwright#11390 (comment)) in some situations) I decided to simply skip for FF. I think this is reasonably pragmatic as we're still testing on Chromium and Webkit.
Problem Statement
Right now, our Playwright integration tests for Replay only cover some simple scenarios without checking recording data too carefully. Due to some bugs/regressions in the past we want to spend some time to ensure these regressions don't keep happening. Due to the fact that our Playwright integration tests are already set up for Replay and they also test against CDN bundles, we want to improve them and add more test cases to ensure better fault detection capability going forward.
Solution Brainstorm
Test setup
Tasks
The text was updated successfully, but these errors were encountered: