Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Replay shim in CDN bundle to avoid breaking in loader #7393

Closed
mydea opened this issue Mar 9, 2023 · 1 comment · Fixed by #7414
Closed

Export Replay shim in CDN bundle to avoid breaking in loader #7393

mydea opened this issue Mar 9, 2023 · 1 comment · Fixed by #7414
Assignees
@mydea
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@mydea
Copy link
Member

mydea commented Mar 9, 2023

When using the new loader setup, users can toggle replay on and off.
When users ship code with replay, and later toggle replay off in the loader config, we want to avoid breaking their app.

To "fix" this, we should export a shim of the integration in the CDN bundles with replay disabled. Since we only provide a very slim API, this should be possible with very little overhead.
@mydea mydea added Type: Feature Package: replay Issues related to the Sentry Replay SDK labels Mar 9, 2023
@mydea mydea self-assigned this Mar 9, 2023
@AbhiPrasad
Copy link
Member

We need to do the same with BrowserTracing too probably.

@mydea mydea mentioned this issue Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bundles): Ensure CDN bundles always have a Replay export getsentry/sentry-javascript
3 participants
@HazAT @mydea @AbhiPrasad