-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundles): Ensure CDN bundles always have a Replay
export
#7414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this LGTM. I think the build error is related to the tracing bundle not being able to resolve the relative path to the shim file.
I guess the one downside here is that this increases the bundle size of the non-replay bundles somewhat unnecessarily. But I understand that this is the lesser of two evils 馃槄
a16ebe8
to
2b85800
Compare
size-limit report 馃摝
|
2b85800
to
bd507e8
Compare
bd507e8
to
2968e20
Compare
This makes sure we export
Replay
in CDN bundles that do not include the actual Replay code.This will export a minimal shim that covers the public API we have, and logs a message.
If we think that's good, we can look to use a similar approach for BrowserTracing (TBD - this is a bit different, but let's see).
Nicely, we can actually cover this quite well with our playwright tests 馃帀
Closes #7393